Merge pull request #460 from tricoder42/issue/459

jessebeach · web-flow · commit 5f4d3439d787 · 2018-07-09T09:08:16.000-07:00
Ignore spread props when checking attributes
diff --git a/__tests__/src/rules/no-noninteractive-element-interactions-test.js b/__tests__/src/rules/no-noninteractive-element-interactions-test.js
@@ -116,7 +116,7 @@ const alwaysValid = [
   { code: '<html onClick={() => {}} />;' },
   { code: '<i onClick={() => {}} />;' },
   { code: '<iframe onLoad={() => {}} />;' },
-  { code: '<img onError={() => {}} />;' },
+  { code: '<img {...props} onError={() => {}} />;' },
   { code: '<img onLoad={() => {}} />;' },
   { code: '<ins onClick={() => {}} />;' },
   { code: '<kbd onClick={() => {}} />;' },
diff --git a/src/rules/no-noninteractive-element-interactions.js b/src/rules/no-noninteractive-element-interactions.js
@@ -60,7 +60,7 @@ module.exports = {
         const interactiveProps = config.handlers || defaultInteractiveProps;
         // Allow overrides from rule configuration for specific elements and roles.
         if (has(config, type)) {
-          attributes = attributes.filter(attr => !includes(config[type], propName(attr)));
+          attributes = attributes.filter(attr => attr.type !== 'JSXSpreadAttribute' && !includes(config[type], propName(attr)));
         }
 
         const hasInteractiveProps = interactiveProps

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ module.exports = {`
`60`	`60`	`const interactiveProps = config.handlers \|\| defaultInteractiveProps;`
`61`	`61`	`// Allow overrides from rule configuration for specific elements and roles.`
`62`	`62`	`if (has(config, type)) {`
`63`		`- attributes = attributes.filter(attr => !includes(config[type], propName(attr)));`
	`63`	`+ attributes = attributes.filter(attr => attr.type !== 'JSXSpreadAttribute' && !includes(config[type], propName(attr)));`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`const hasInteractiveProps = interactiveProps`