[new] - Use airbnb eslint config (#58)

Author: beefancohen

.eslintrc

@@ -0,0 +1,3 @@
+{
+  extends: "airbnb-base"
+}

.eslintrc.js

@@ -20,7 +20,7 @@
     "build": "rimraf lib && babel src --out-dir lib && cp -R src/util/attributes lib/util/attributes",
     "prepublish": "npm run lint && npm run test && npm run build",
     "coveralls": "cat ./reports/coverage/lcov.info | coveralls",
-    "lint": "eslint  --config .eslintrc.js .",
+    "lint": "eslint  --config .eslintrc src tests",
     "pretest": "npm run lint",
     "test": "istanbul cover --dir reports/coverage node_modules/mocha/bin/_mocha tests/**/*.js -- --compilers js:babel-core/register --reporter dot"
   },
@@ -31,6 +31,8 @@
     "babel-preset-es2015": "^6.6.0",
     "coveralls": "^2.11.8",
     "eslint": "^2.2.0",
+    "eslint-config-airbnb-base": "^3.0.1",
+    "eslint-plugin-import": "^1.8.1",
     "istanbul": "^1.0.0-alpha.2",
     "mocha": "^2.4.5",
     "rimraf": "^2.5.2"

package.json

@@ -1,4 +1,4 @@
-'use strict';
+/* eslint-disable global-require */
 
 module.exports = {
   rules: {
@@ -17,14 +17,14 @@ module.exports = {
     'onclick-has-role': require('./rules/onclick-has-role'),
     'role-has-required-aria-props': require('./rules/role-has-required-aria-props'),
     'role-supports-aria-props': require('./rules/role-supports-aria-props'),
-    'tabindex-no-positive': require('./rules/tabindex-no-positive')
+    'tabindex-no-positive': require('./rules/tabindex-no-positive'),
   },
   configs: {
     recommended: {
       parserOptions: {
         ecmaFeatures: {
-          jsx: true
-        }
+          jsx: true,
+        },
       },
       rules: {
         'jsx-a11y/aria-props': 2,
@@ -42,8 +42,8 @@ module.exports = {
         'jsx-a11y/onclick-has-role': 2,
         'jsx-a11y/role-has-required-aria-props': 2,
         'jsx-a11y/role-supports-aria-props': 2,
-        'jsx-a11y/tabindex-no-positive': 2
-      }
-    }
-  }
+        'jsx-a11y/tabindex-no-positive': 2,
+      },
+    },
+  },
 };

src/index.js

@@ -2,7 +2,6 @@
  * @fileoverview Enforce all aria-* properties are valid.
  * @author Ethan Cohen
  */
-'use strict';
 
 // ----------------------------------------------------------------------------
 // Rule Definition
@@ -38,12 +37,12 @@ module.exports = context => ({
     if (isValid === false) {
       context.report({
         node: attribute,
-        message: errorMessage(name)
+        message: errorMessage(name),
       });
     }
-  }
+  },
 });
 
 module.exports.schema = [
-  { type: 'object' }
+  { type: 'object' },
 ];

src/rules/aria-props.js

@@ -2,7 +2,6 @@
  * @fileoverview Enforce ARIA state and property values are valid.
  * @author Ethan Cohen
  */
-'use strict';
 
 // ----------------------------------------------------------------------------
 // Rule Definition
@@ -18,7 +17,8 @@ const errorMessage = (name, type, permittedValues) => {
     case 'token':
       return `The value for ${name} must be a single token from the following: ${permittedValues}.`;
     case 'tokenlist':
-      return `The value for ${name} must be a list of one or more tokens from the following: ${permittedValues}.`;
+      return `The value for ${name} must be a list of one or more \
+tokens from the following: ${permittedValues}.`;
     case 'boolean':
     case 'string':
     case 'integer':
@@ -35,15 +35,16 @@ const validityCheck = (value, expectedType, permittedValues) => {
     case 'string':
       return typeof value === 'string';
     case 'tristate':
-      return typeof value === 'boolean' || value == 'mixed';
+      return typeof value === 'boolean' || value === 'mixed';
     case 'integer':
     case 'number':
       // Booleans resolve to 0/1 values so hard check that it's not first.
       return typeof value !== 'boolean' && isNaN(Number(value)) === false;
     case 'token':
       return typeof value === 'string' && permittedValues.indexOf(value.toLowerCase()) > -1;
     case 'tokenlist':
-      return typeof value === 'string' && value.split(' ').every(token => permittedValues.indexOf(token.toLowerCase()) > -1);
+      return typeof value === 'string' &&
+        value.split(' ').every(token => permittedValues.indexOf(token.toLowerCase()) > -1);
     default:
       return false;
   }
@@ -72,19 +73,20 @@ module.exports = context => ({
     const allowUndefined = attributes.allowUndefined || false;
     const permittedValues = attributes.values || [];
 
-    const isValid = validityCheck(value, permittedType, permittedValues) || (allowUndefined && value === undefined);
+    const isValid = validityCheck(value, permittedType, permittedValues) ||
+      (allowUndefined && value === undefined);
 
     if (isValid) {
       return;
     }
 
     context.report({
       node: attribute,
-      message: errorMessage(name, permittedType, permittedValues)
+      message: errorMessage(name, permittedType, permittedValues),
     });
-  }
+  },
 });
 
 module.exports.schema = [
-  { type: 'object' }
+  { type: 'object' },
 ];

src/rules/aria-proptypes.js

@@ -2,7 +2,6 @@
  * @fileoverview Enforce aria role attribute is valid.
  * @author Ethan Cohen
  */
-'use strict';
 
 // ----------------------------------------------------------------------------
 // Rule Definition
@@ -23,26 +22,27 @@ module.exports = context => ({
     const value = getLiteralPropValue(attribute);
 
     // If value is undefined, then the role attribute will be dropped in the DOM.
-    // If value is null, then getLiteralAttributeValue is telling us that the value isn't in the form of a literal.
+    // If value is null, then getLiteralAttributeValue is telling us that the
+    // value isn't in the form of a literal.
     if (value === undefined || value === null) {
       return;
     }
 
     const normalizedValues = String(value).toUpperCase().split(' ');
     const validRoles = Object.keys(roles).filter(role => roles[role].abstract === false);
-    const isValid = normalizedValues.every(value => validRoles.indexOf(value) > -1);
+    const isValid = normalizedValues.every(val => validRoles.indexOf(val) > -1);
 
     if (isValid === true) {
       return;
     }
 
     context.report({
       node: attribute,
-      message: errorMessage
+      message: errorMessage,
     });
-  }
+  },
 });
 
 module.exports.schema = [
-  { type: 'object' }
+  { type: 'object' },
 ];

src/rules/aria-role.js

@@ -1,8 +1,8 @@
 /**
- * @fileoverview Enforce that elements that do not support ARIA roles, states and properties do not have those attributes.
+ * @fileoverview Enforce that elements that do not support ARIA roles,
+ *  states and properties do not have those attributes.
  * @author Ethan Cohen
  */
-'use strict';
 
 // ----------------------------------------------------------------------------
 // Rule Definition
@@ -13,7 +13,8 @@ import ARIA from '../util/attributes/ARIA';
 import { elementType } from 'jsx-ast-utils';
 
 const errorMessage = invalidProp =>
-  `This element does not support ARIA roles, states and properties. Try removing the prop '${invalidProp}'.`;
+  `This element does not support ARIA roles, states and properties. \
+Try removing the prop '${invalidProp}'.`;
 
 module.exports = context => ({
   JSXOpeningElement: node => {
@@ -32,13 +33,13 @@ module.exports = context => ({
       if (invalidAttributes.indexOf(prop.name.name.toUpperCase()) > -1) {
         context.report({
           node,
-          message: errorMessage(prop.name.name)
+          message: errorMessage(prop.name.name),
         });
       }
     });
-  }
+  },
 });
 
 module.exports.schema = [
-  { type: 'object' }
+  { type: 'object' },
 ];