Fix: backward compatibility with node.js v4 and v5. (#231)

Author: evilebottnawi

package.json

@@ -55,6 +55,7 @@
   "license": "MIT",
   "dependencies": {
     "aria-query": "^0.5.0",
+    "array-includes": "^3.0.3",
     "ast-types-flow": "0.0.7",
     "axobject-query": "^0.1.0",
     "damerau-levenshtein": "^1.0.0",

src/rules/click-events-have-key-events.js

@@ -11,6 +11,7 @@ import {
   dom,
 } from 'aria-query';
 import { getProp, hasAnyProp, elementType } from 'jsx-ast-utils';
+import includes from 'array-includes';
 import { generateObjSchema } from '../util/schemas';
 import isHiddenFromScreenReader from '../util/isHiddenFromScreenReader';
 import isInteractiveElement from '../util/isInteractiveElement';
@@ -37,7 +38,7 @@ module.exports = {
       const type = elementType(node);
       const requiredProps = ['onkeydown', 'onkeyup', 'onkeypress'];
 
-      if (!domElements.includes(type)) {
+      if (!includes(domElements, type)) {
         // Do not test higher level JSX components, as we do not know what
         // low-level DOM element this maps to.
         return;

src/rules/interactive-supports-focus.js

@@ -12,6 +12,7 @@ import {
   hasAnyProp,
 } from 'jsx-ast-utils';
 import type { JSXOpeningElement } from 'ast-types-flow';
+import includes from 'array-includes';
 import { generateObjSchema } from '../util/schemas';
 import isHiddenFromScreenReader from '../util/isHiddenFromScreenReader';
 import isInteractiveElement from '../util/isInteractiveElement';
@@ -53,7 +54,7 @@ module.exports = {
         getProp(attributes, 'tabIndex'),
       ) !== undefined;
 
-      if (!domElements.includes(type)) {
+      if (!includes(domElements, type)) {
         // Do not test higher level JSX components, as we do not know what
         // low-level DOM element this maps to.
         return;

src/rules/no-interactive-element-to-noninteractive-role.js

@@ -19,6 +19,7 @@ import {
   propName,
 } from 'jsx-ast-utils';
 import type { JSXIdentifier } from 'ast-types-flow';
+import includes from 'array-includes';
 import isInteractiveElement from '../util/isInteractiveElement';
 import isNonInteractiveRole from '../util/isNonInteractiveRole';
 import isPresentationRole from '../util/isPresentationRole';
@@ -58,7 +59,7 @@ module.exports = {
         const type = elementType(node);
         const role = getLiteralPropValue(getProp(node.attributes, 'role'));
 
-        if (!domElements.includes(type)) {
+        if (!includes(domElements, type)) {
           // Do not test higher level JSX components, as we do not know what
           // low-level DOM element this maps to.
           return;
@@ -68,7 +69,7 @@ module.exports = {
         const allowedRoles = (options[0] || {});
         if (
           Object.prototype.hasOwnProperty.call(allowedRoles, type)
-          && allowedRoles[type].includes(role)
+          && includes(allowedRoles[type], role)
         ) {
           return;
         }

src/rules/no-noninteractive-element-interactions.js

@@ -18,6 +18,7 @@ import {
   hasProp,
 } from 'jsx-ast-utils';
 import type { JSXOpeningElement } from 'ast-types-flow';
+import includes from 'array-includes';
 import { arraySchema, generateObjSchema } from '../util/schemas';
 import isAbstractRole from '../util/isAbstractRole';
 import isHiddenFromScreenReader from '../util/isHiddenFromScreenReader';
@@ -60,7 +61,7 @@ module.exports = {
             && getPropValue(getProp(attributes, prop)) != null
           ));
 
-        if (!domElements.includes(type)) {
+        if (!includes(domElements, type)) {
           // Do not test higher level JSX components, as we do not know what
           // low-level DOM element this maps to.
           return;

src/rules/no-noninteractive-element-to-interactive-role.js

@@ -20,6 +20,7 @@ import {
 import type {
   JSXIdentifier,
 } from 'ast-types-flow';
+import includes from 'array-includes';
 import isNonInteractiveElement from '../util/isNonInteractiveElement';
 import isInteractiveRole from '../util/isInteractiveRole';
 
@@ -58,7 +59,7 @@ module.exports = {
         const type = elementType(node);
         const role = getLiteralPropValue(getProp(node.attributes, 'role'));
 
-        if (!domElements.includes(type)) {
+        if (!includes(domElements, type)) {
           // Do not test higher level JSX components, as we do not know what
           // low-level DOM element this maps to.
           return;
@@ -68,7 +69,7 @@ module.exports = {
         const allowedRoles = (options[0] || {});
         if (
           Object.prototype.hasOwnProperty.call(allowedRoles, type)
-          && allowedRoles[type].includes(role)
+          && includes(allowedRoles[type], role)
         ) {
           return;
         }

src/rules/no-noninteractive-tabindex.js

@@ -16,6 +16,7 @@ import {
   getProp,
   getLiteralPropValue,
 } from 'jsx-ast-utils';
+import includes from 'array-includes';
 import isInteractiveElement from '../util/isInteractiveElement';
 import isInteractiveRole from '../util/isInteractiveRole';
 import { generateObjSchema, arraySchema } from '../util/schemas';
@@ -71,8 +72,8 @@ module.exports = {
           roles,
         } = (options[0] || {});
         if (
-          (tags && tags.includes(type))
-          || (roles && roles.includes(role))
+          (tags && includes(tags, type))
+          || (roles && includes(roles, role))
         ) {
           return;
         }

src/rules/no-static-element-interactions.js

@@ -19,6 +19,7 @@ import {
   hasProp,
 } from 'jsx-ast-utils';
 import type { JSXOpeningElement } from 'ast-types-flow';
+import includes from 'array-includes';
 import { arraySchema, generateObjSchema } from '../util/schemas';
 import isAbstractRole from '../util/isAbstractRole';
 import isHiddenFromScreenReader from '../util/isHiddenFromScreenReader';
@@ -61,7 +62,7 @@ module.exports = {
             && getPropValue(getProp(attributes, prop)) != null
           ));
 
-        if (!domElements.includes(type)) {
+        if (!includes(domElements, type)) {
           // Do not test higher level JSX components, as we do not know what
           // low-level DOM element this maps to.
           return;

src/util/isInteractiveElement.js

@@ -11,6 +11,7 @@ import {
   AXObjects,
   elementAXObjects,
 } from 'axobject-query';
+import includes from 'array-includes';
 import attributesComparator from './attributesComparator';
 
 const roleKeys = [...roles.keys()];
@@ -23,7 +24,7 @@ const nonInteractiveRoles = new Set(
       return (
         !role.abstract
         && !role.superClass.some(
-          classes => classes.includes('widget'),
+          classes => includes(classes, 'widget'),
         )
       );
     }),
@@ -41,7 +42,7 @@ const interactiveRoles = new Set(
       return (
         !role.abstract
         && role.superClass.some(
-          classes => classes.includes('widget'),
+          classes => includes(classes, 'widget'),
         )
       );
     }),

src/util/isInteractiveRole.js

@@ -4,12 +4,13 @@ import {
 } from 'aria-query';
 import type { Node } from 'ast-types-flow';
 import { getProp, getLiteralPropValue } from 'jsx-ast-utils';
+import includes from 'array-includes';
 
 const roles = [...rolesMap.keys()];
 const interactiveRoles = roles
   .filter(name => !rolesMap.get(name).abstract)
   .filter(name => rolesMap.get(name).superClass.some(
-    klasses => klasses.includes('widget')),
+    klasses => includes(klasses, 'widget')),
   );
 
 // 'toolbar' does not descend from widget, but it does support
@@ -45,14 +46,14 @@ const isInteractiveRole = (
     accumulator: Array<string>,
     name: string,
   ) => {
-    if (roles.includes(name)) {
+    if (includes(roles, name)) {
       accumulator.push(name);
     }
     return accumulator;
   }, []);
   if (validRoles.length > 0) {
     // The first role value is a series takes precedence.
-    isInteractive = interactiveRoles.includes(validRoles[0]);
+    isInteractive = includes(interactiveRoles, validRoles[0]);
   }
 
   return isInteractive;