Merge pull request #650 from evcohen/chore-update-dependencies

Updated dependencies including eslint-config-airbnb-base

Author: jessebeach

__mocks__/genInteractives.js

@@ -119,9 +119,9 @@ Object.keys(interactiveElementsMap)
   .concat(Object.keys(nonInteractiveElementsMap))
   .forEach((name: string) => delete indeterminantInteractiveElementsMap[name]);
 
-const abstractRoles = roleNames.filter(role => roles.get(role).abstract);
+const abstractRoles = roleNames.filter((role) => roles.get(role).abstract);
 
-const nonAbstractRoles = roleNames.filter(role => !roles.get(role).abstract);
+const nonAbstractRoles = roleNames.filter((role) => !roles.get(role).abstract);
 
 const interactiveRoles = []
   .concat(
@@ -130,21 +130,21 @@ const interactiveRoles = []
     // aria-activedescendant, thus in practice we treat it as a widget.
     'toolbar',
   )
-  .filter(role => !roles.get(role).abstract)
-  .filter(role => roles.get(role).superClass.some(klasses => includes(klasses, 'widget')));
+  .filter((role) => !roles.get(role).abstract)
+  .filter((role) => roles.get(role).superClass.some((klasses) => includes(klasses, 'widget')));
 
 const nonInteractiveRoles = roleNames
-  .filter(role => !roles.get(role).abstract)
-  .filter(role => !roles.get(role).superClass.some(klasses => includes(klasses, 'widget')))
+  .filter((role) => !roles.get(role).abstract)
+  .filter((role) => !roles.get(role).superClass.some((klasses) => includes(klasses, 'widget')))
   // 'toolbar' does not descend from widget, but it does support
   // aria-activedescendant, thus in practice we treat it as a widget.
-  .filter(role => !includes(['toolbar'], role));
+  .filter((role) => !includes(['toolbar'], role));
 
 export function genElementSymbol(openingElement: Object) {
   return (
     openingElement.name.name + (openingElement.attributes.length > 0
       ? `${openingElement.attributes
-        .map(attr => `[${attr.name.name}="${attr.value.value}"]`)
+        .map((attr) => `[${attr.name.name}="${attr.value.value}"]`)
         .join('')}`
       : ''
     )
@@ -187,15 +187,15 @@ export function genNonInteractiveRoleElements() {
     ...nonInteractiveRoles,
     'article button',
     'fakerole article button',
-  ].map(value => JSXElementMock('div', [JSXAttributeMock('role', value)]));
+  ].map((value) => JSXElementMock('div', [JSXAttributeMock('role', value)]));
 }
 
 export function genAbstractRoleElements() {
-  return abstractRoles.map(value => JSXElementMock('div', [JSXAttributeMock('role', value)]));
+  return abstractRoles.map((value) => JSXElementMock('div', [JSXAttributeMock('role', value)]));
 }
 
 export function genNonAbstractRoleElements() {
-  return nonAbstractRoles.map(value => JSXElementMock('div', [JSXAttributeMock('role', value)]));
+  return nonAbstractRoles.map((value) => JSXElementMock('div', [JSXAttributeMock('role', value)]));
 }
 
 export function genIndeterminantInteractiveElements(): Array<TJSXElementMock> {

__tests__/index-test.js

@@ -7,7 +7,7 @@ import path from 'path';
 import plugin from '../src';
 
 const rules = fs.readdirSync(path.resolve(__dirname, '../src/rules/'))
-  .map(f => path.basename(f, '.js'));
+  .map((f) => path.basename(f, '.js'));
 
 describe('all rule files should be exported by the plugin', () => {
   rules.forEach((ruleName) => {

__tests__/src/rules/alt-text-test.js

@@ -18,12 +18,12 @@ import rule from '../../../src/rules/alt-text';
 
 const ruleTester = new RuleTester();
 
-const missingPropError = type => ({
+const missingPropError = (type) => ({
   message: `${type} elements must have an alt prop, either with meaningful text, or an empty string for decorative images.`,
   type: 'JSXOpeningElement',
 });
 
-const altValueError = type => ({
+const altValueError = (type) => ({
   message: `Invalid alt value for ${type}. \
 Use alt="" for presentational images.`,
   type: 'JSXOpeningElement',

__tests__/src/rules/aria-props-test.js

@@ -39,7 +39,7 @@ const errorMessage = (name) => {
 };
 
 // Create basic test cases using all valid role types.
-const basicValidityTests = ariaAttributes.map(prop => ({
+const basicValidityTests = ariaAttributes.map((prop) => ({
   code: `<div ${prop.toLowerCase()}="foobar" />`,
 }));
 

__tests__/src/rules/aria-role-test.js

@@ -26,16 +26,16 @@ const errorMessage = {
 
 const roleKeys = [...roles.keys()];
 
-const validRoles = roleKeys.filter(role => roles.get(role).abstract === false);
-const invalidRoles = roleKeys.filter(role => roles.get(role).abstract === true);
+const validRoles = roleKeys.filter((role) => roles.get(role).abstract === false);
+const invalidRoles = roleKeys.filter((role) => roles.get(role).abstract === true);
 
-const createTests = roleNames => roleNames.map(role => ({
+const createTests = (roleNames) => roleNames.map((role) => ({
   code: `<div role="${role.toLowerCase()}" />`,
 }));
 
 const validTests = createTests(validRoles);
 const invalidTests = createTests(invalidRoles).map((test) => {
-  const invalidTest = Object.assign({}, test);
+  const invalidTest = { ...test };
   invalidTest.errors = [errorMessage];
   return invalidTest;
 });

__tests__/src/rules/aria-unsupported-elements-test.js

@@ -20,7 +20,7 @@ import rule from '../../../src/rules/aria-unsupported-elements';
 
 const ruleTester = new RuleTester();
 
-const errorMessage = invalidProp => ({
+const errorMessage = (invalidProp) => ({
   message: `This element does not support ARIA roles, states and properties. \
 Try removing the prop '${invalidProp}'.`,
   type: 'JSXOpeningElement',
@@ -51,15 +51,15 @@ const ariaValidityTests = domElements.map((element) => {
 
 // Generate invalid test cases.
 const invalidRoleValidityTests = domElements
-  .filter(element => Boolean(dom.get(element).reserved))
-  .map(reservedElem => ({
+  .filter((element) => Boolean(dom.get(element).reserved))
+  .map((reservedElem) => ({
     code: `<${reservedElem} role {...props} />`,
     errors: [errorMessage('role')],
   }));
 
 const invalidAriaValidityTests = domElements
-  .filter(element => Boolean(dom.get(element).reserved))
-  .map(reservedElem => ({
+  .filter((element) => Boolean(dom.get(element).reserved))
+  .map((reservedElem) => ({
     code: `<${reservedElem} aria-hidden aria-role="none" {...props} />`,
     errors: [errorMessage('aria-hidden')],
   }));

__tests__/src/rules/interactive-supports-focus-test.js

@@ -170,7 +170,7 @@ const triggeringHandlers = [
 const passReducer = (roles, handlers, messageTemplate) => (
   staticElements.reduce((elementAcc, element) => (
     elementAcc.concat(roles.reduce((roleAcc, role) => (
-      roleAcc.concat(handlers.map(handler => ({
+      roleAcc.concat(handlers.map((handler) => ({
         code: messageTemplate(element, role, handler),
       })))
     ), []))
@@ -180,7 +180,7 @@ const passReducer = (roles, handlers, messageTemplate) => (
 const failReducer = (roles, handlers, messageTemplate) => (
   staticElements.reduce((elementAcc, element) => (
     elementAcc.concat(roles.reduce((roleAcc, role) => (
-      roleAcc.concat(handlers.map(handler => ({
+      roleAcc.concat(handlers.map((handler) => ({
         code: codeTemplate(element, role, handler),
         errors: [{
           type,
@@ -196,12 +196,12 @@ ruleTester.run(`${ruleName}:recommended`, rule, {
     ...alwaysValid,
     ...passReducer(
       interactiveRoles,
-      eventHandlers.filter(handler => !includes(triggeringHandlers, handler)),
+      eventHandlers.filter((handler) => !includes(triggeringHandlers, handler)),
       codeTemplate,
     ),
     ...passReducer(
-      interactiveRoles.filter(role => !includes(recommendedRoles, role)),
-      eventHandlers.filter(handler => includes(triggeringHandlers, handler)),
+      interactiveRoles.filter((role) => !includes(recommendedRoles, role)),
+      eventHandlers.filter((handler) => includes(triggeringHandlers, handler)),
       tabindexTemplate,
     ),
   ]
@@ -210,7 +210,7 @@ ruleTester.run(`${ruleName}:recommended`, rule, {
   invalid: [
     ...failReducer(recommendedRoles, triggeringHandlers, tabbableTemplate),
     ...failReducer(
-      interactiveRoles.filter(role => !includes(recommendedRoles, role)),
+      interactiveRoles.filter((role) => !includes(recommendedRoles, role)),
       triggeringHandlers,
       focusableTemplate,
     ),
@@ -224,12 +224,12 @@ ruleTester.run(`${ruleName}:strict`, rule, {
     ...alwaysValid,
     ...passReducer(
       interactiveRoles,
-      eventHandlers.filter(handler => !includes(triggeringHandlers, handler)),
+      eventHandlers.filter((handler) => !includes(triggeringHandlers, handler)),
       codeTemplate,
     ),
     ...passReducer(
-      interactiveRoles.filter(role => !includes(strictRoles, role)),
-      eventHandlers.filter(handler => includes(triggeringHandlers, handler)),
+      interactiveRoles.filter((role) => !includes(strictRoles, role)),
+      eventHandlers.filter((handler) => includes(triggeringHandlers, handler)),
       tabindexTemplate,
     ),
   ]
@@ -238,7 +238,7 @@ ruleTester.run(`${ruleName}:strict`, rule, {
   invalid: [
     ...failReducer(strictRoles, triggeringHandlers, tabbableTemplate),
     ...failReducer(
-      interactiveRoles.filter(role => !includes(strictRoles, role)),
+      interactiveRoles.filter((role) => !includes(strictRoles, role)),
       triggeringHandlers,
       focusableTemplate,
     ),

__tests__/src/rules/no-distracting-elements-test.js

@@ -18,7 +18,7 @@ import rule from '../../../src/rules/no-distracting-elements';
 
 const ruleTester = new RuleTester();
 
-const expectedError = element => ({
+const expectedError = (element) => ({
   message: `Do not use <${element}> elements as they can create visual accessibility issues and are deprecated.`,
   type: 'JSXOpeningElement',
 });

__tests__/src/rules/role-supports-aria-props-test.js

@@ -36,25 +36,25 @@ const errorMessage = (attr, role, tag, isImplicit) => ({
   type: 'JSXOpeningElement',
 });
 
-const nonAbstractRoles = [...roles.keys()].filter(role => roles.get(role).abstract === false);
+const nonAbstractRoles = [...roles.keys()].filter((role) => roles.get(role).abstract === false);
 
-const createTests = rolesNames => rolesNames.reduce((tests, role) => {
+const createTests = (rolesNames) => rolesNames.reduce((tests, role) => {
   const {
     props: propKeyValues,
   } = roles.get(role);
   const validPropsForRole = Object.keys(propKeyValues);
   const invalidPropsForRole = [...aria.keys()]
-    .map(attribute => attribute.toLowerCase())
-    .filter(attribute => validPropsForRole.indexOf(attribute) === -1);
+    .map((attribute) => attribute.toLowerCase())
+    .filter((attribute) => validPropsForRole.indexOf(attribute) === -1);
   const normalRole = role.toLowerCase();
 
   const allTests = [];
 
-  allTests[0] = tests[0].concat(validPropsForRole.map(prop => ({
+  allTests[0] = tests[0].concat(validPropsForRole.map((prop) => ({
     code: `<div role="${normalRole}" ${prop.toLowerCase()} />`,
   })));
 
-  allTests[1] = tests[1].concat(invalidPropsForRole.map(prop => ({
+  allTests[1] = tests[1].concat(invalidPropsForRole.map((prop) => ({
     code: `<div role="${normalRole}" ${prop.toLowerCase()} />`,
     errors: [errorMessage(prop.toLowerCase(), normalRole, 'div', false)],
   })));

package.json

@@ -38,18 +38,18 @@
     "babel-preset-airbnb": "^4.0.0",
     "coveralls": "^3.0.1",
     "eslint": "^3 || ^4 || ^5 || ^6",
-    "eslint-config-airbnb-base": "^13.0.0",
-    "eslint-plugin-flowtype": "^3.5.0",
+    "eslint-config-airbnb-base": "^14.0.0",
+    "eslint-plugin-flowtype": "^4.5.2",
     "eslint-plugin-import": "^2.18.0",
     "estraverse": "^4.2.0",
     "expect": "^24.3.1",
-    "flow-bin": "^0.103.0",
+    "flow-bin": "^0.112.0",
     "in-publish": "^2.0.0",
     "jest": "^24.0.0",
     "jscodeshift": "^0.6.0",
     "minimist": "^1.2.0",
     "object.assign": "^4.1.0",
-    "rimraf": "^2.6.3",
+    "rimraf": "^3.0.0",
     "safe-publish-latest": "^1.1.1",
     "to-ast": "^1.0.0"
   },