[chore]: outlier test cases

Author: sarahvharris

__tests__/src/rules/no-static-element-interactions-test.js

@@ -34,12 +34,24 @@ const componentsSettings = {
     components: {
       Button: 'button',
       TestComponent: 'div',
+      // Custom component with mapped attributes
       Link: {
         component: 'a',
         attributes: {
-          href: ['to', 'href'],
+          href: ['to', 'href', 'foo'],
         },
       },
+      // Custom component with a redundant attribute
+      TestComponent2: {
+        attributes: {
+          href: ['href'],
+        },
+        component: 'a',
+      },
+      // Custom component with empty attributes object
+      TestComponent3: {
+        component: 'a',
+      },
     },
   },
 };
@@ -89,7 +101,9 @@ const alwaysValid = [
   { code: '<a onClick={() => void 0} href="http://x.y.z" />' },
   { code: '<a onClick={() => void 0} href="http://x.y.z" tabIndex="0" />' },
   { code: '<Link onClick={() => void 0} to="path/to/page" />', settings: componentsSettings },
+  { code: '<Link onClick={() => void 0} foo="path/to/page" />', settings: componentsSettings },
   { code: '<Link onClick={() => void 0} href="http://x.y.z" />', settings: componentsSettings },
+  { code: '<TestComponent2 onClick={() => void 0} href="http://x.y.z" />;', settings: componentsSettings },
   { code: '<audio onClick={() => {}} />;' },
   { code: '<form onClick={() => {}} />;' },
   { code: '<form onSubmit={() => {}} />;' },
@@ -365,6 +379,10 @@ const neverValid = [
   // Custom components
   { code: '<Link onClick={() => void 0} to="path/to/page" />', settings: { 'jsx-a11y': { components: { Link: 'a' } } }, errors: [expectedError] },
   { code: '<TestComponent onClick={() => void 0} to="path/to/page" />', settings: componentsSettings, errors: [expectedError] },
+  // Custom component with a redundant attribute
+  { code: '<TestComponent2 onClick={() => void 0} to="path/to/page" />;', settings: componentsSettings, errors: [expectedError] },
+  // Custom component with empty attributes object
+  { code: '<TestComponent3 onClick={() => void 0} to="path/to/page" />;', settings: componentsSettings, errors: [expectedError] },
   // `a` with a `to` is not valid, only custom components listed in `components`
   { code: '<a onClick={() => void 0} to="path/to/page" />', settings: componentsSettings, errors: [expectedError] },
 ];

src/util/getElementType.js

@@ -33,15 +33,19 @@ const getElementType = (context: ESLintContext): ((node: JSXOpeningElement) => s
 
     const componentType = componentMap[rawType];
 
+    if (typeof componentType === 'string') {
+      return hasOwn(componentMap, rawType) ? componentType : rawType;
+    }
+
     if (typeof componentType === 'object') {
+      if (componentType.component) return componentType.component;
+
       const customComponent = Object.entries(componentType).find(([key]) => key === rawType);
 
       if (customComponent) {
         [rawType] = customComponent;
         return hasOwn(componentMap, rawType) ? rawType : rawType;
       }
-    } else if (typeof componentType === 'string') {
-      return hasOwn(componentMap, rawType) ? componentType : rawType;
     }
 
     return rawType;