Skip to content

Commit 04c0d5f

Browse files
committed
Rewrite no-render-return-value tests with template literals
1 parent a0056b3 commit 04c0d5f

File tree

1 file changed

+17
-22
lines changed

1 file changed

+17
-22
lines changed

tests/lib/rules/no-render-return-value.js

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,12 @@ const ruleTester = new RuleTester({parserOptions});
2828
ruleTester.run('no-render-return-value', rule, {
2929

3030
valid: [{
31-
code: [
32-
'ReactDOM.render(<div />, document.body);'
33-
].join('\n')
31+
code: 'ReactDOM.render(<div />, document.body);'
3432
}, {
35-
code: [
36-
'let node;',
37-
'ReactDOM.render(<div ref={ref => node = ref}/>, document.body);'
38-
].join('\n')
33+
code: `
34+
let node;
35+
ReactDOM.render(<div ref={ref => node = ref}/>, document.body);
36+
`
3937
}, {
4038
code: 'ReactDOM.render(<div ref={ref => this.node = ref}/>, document.body);',
4139
settings: {
@@ -57,31 +55,28 @@ ruleTester.run('no-render-return-value', rule, {
5755
version: '0.13.0'
5856
}
5957
}
60-
}
61-
],
58+
}],
6259

6360
invalid: [{
64-
code: [
65-
'var Hello = ReactDOM.render(<div />, document.body);'
66-
].join('\n'),
61+
code: 'var Hello = ReactDOM.render(<div />, document.body);',
6762
errors: [{
6863
message: 'Do not depend on the return value from ReactDOM.render'
6964
}]
7065
}, {
71-
code: [
72-
'var o = {',
73-
' inst: ReactDOM.render(<div />, document.body)',
74-
'};'
75-
].join('\n'),
66+
code: `
67+
var o = {
68+
inst: ReactDOM.render(<div />, document.body)
69+
};
70+
`,
7671
errors: [{
7772
message: 'Do not depend on the return value from ReactDOM.render'
7873
}]
7974
}, {
80-
code: [
81-
'function render () {',
82-
' return ReactDOM.render(<div />, document.body)',
83-
'}'
84-
].join('\n'),
75+
code: `
76+
function render () {
77+
return ReactDOM.render(<div />, document.body)
78+
}
79+
`,
8580
errors: [{
8681
message: 'Do not depend on the return value from ReactDOM.render'
8782
}]

0 commit comments

Comments
 (0)