jsx-child-element-spacing: support shorthand fragments

Author: alexzherdev

lib/rules/jsx-child-element-spacing.js

@@ -68,39 +68,42 @@ module.exports = {
       INLINE_ELEMENTS.has(elementName(node))
     );
 
+    const handleJSX = node => {
+      let lastChild = null;
+      let child = null;
+      (node.children.concat([null])).forEach(nextChild => {
+        if (
+          (lastChild || nextChild) &&
+          (!lastChild || isInlineElement(lastChild)) &&
+          (child && (child.type === 'Literal' || child.type === 'JSXText')) &&
+          (!nextChild || isInlineElement(nextChild)) &&
+          true
+        ) {
+          if (lastChild && child.value.match(TEXT_FOLLOWING_ELEMENT_PATTERN)) {
+            context.report({
+              node: lastChild,
+              loc: lastChild.loc.end,
+              message: `Ambiguous spacing after previous element ${elementName(lastChild)}`
+            });
+          } else if (nextChild && child.value.match(TEXT_PRECEDING_ELEMENT_PATTERN)) {
+            context.report({
+              node: nextChild,
+              loc: nextChild.loc.start,
+              message: `Ambiguous spacing before next element ${elementName(nextChild)}`
+            });
+          }
+        }
+        lastChild = child;
+        child = nextChild;
+      });
+    };
+
     const TEXT_FOLLOWING_ELEMENT_PATTERN = /^\s*\n\s*\S/;
     const TEXT_PRECEDING_ELEMENT_PATTERN = /\S\s*\n\s*$/;
 
     return {
-      JSXElement: function(node) {
-        let lastChild = null;
-        let child = null;
-        (node.children.concat([null])).forEach(nextChild => {
-          if (
-            (lastChild || nextChild) &&
-            (!lastChild || isInlineElement(lastChild)) &&
-            (child && (child.type === 'Literal' || child.type === 'JSXText')) &&
-            (!nextChild || isInlineElement(nextChild)) &&
-            true
-          ) {
-            if (lastChild && child.value.match(TEXT_FOLLOWING_ELEMENT_PATTERN)) {
-              context.report({
-                node: lastChild,
-                loc: lastChild.loc.end,
-                message: `Ambiguous spacing after previous element ${elementName(lastChild)}`
-              });
-            } else if (nextChild && child.value.match(TEXT_PRECEDING_ELEMENT_PATTERN)) {
-              context.report({
-                node: nextChild,
-                loc: nextChild.loc.start,
-                message: `Ambiguous spacing before next element ${elementName(nextChild)}`
-              });
-            }
-          }
-          lastChild = child;
-          child = nextChild;
-        });
-      }
+      JSXElement: handleJSX,
+      JSXFragment: handleJSX
     };
   }
 };

tests/lib/rules/jsx-child-element-spacing.js

@@ -17,6 +17,13 @@ ruleTester.run('jsx-child-element-spacing', rule, {
         foo
       </App>
     `
+  }, {
+    code: `
+      <>
+        foo
+      </>
+    `,
+    parser: 'babel-eslint'
   }, {
     code: `
       <App>
@@ -146,6 +153,21 @@ ruleTester.run('jsx-child-element-spacing', rule, {
     ]
   }, {
     code: `
+<>
+  foo
+  <a>bar</a>
+</>
+    `,
+    parser: 'babel-eslint',
+    errors: [
+      {
+        message: 'Ambiguous spacing before next element a',
+        line: 4,
+        column: 3
+      }
+    ]
+  }, {
+    code: `
 <App>
   <a>bar</a>
   baz