Fix failing tests

Author: y-hsgw

lib/rules/button-has-type.js

@@ -151,7 +151,7 @@ module.exports = {
 
         const props = node.arguments[1].properties;
         const typeProp = props.find(
-          (prop) => prop.type === 'Property' && prop.key && prop.key.type === 'PrivateIdentifier' && prop.key.name === 'type'
+          (prop) => prop.type === 'Property' && prop.key && prop.key.type === 'Identifier' && prop.key.name === 'type'
         );
 
         if (typeProp.type !== 'Property') {

lib/rules/no-access-state-in-setstate.js

@@ -102,7 +102,7 @@ module.exports = {
 
       MemberExpression(node) {
         if (
-          node.property.type === 'PrivateIdentifier'
+          node.property.type === 'Identifier'
           && node.property.name === 'state'
           && node.object.type === 'ThisExpression'
           && isClassComponent()
@@ -188,7 +188,7 @@ module.exports = {
       ObjectPattern(node) {
         const isDerivedFromThis = (node.parent.type === 'ForStatement' || node.parent.type === 'VariableDeclarator') && node.parent.init && node.parent.init.type === 'ThisExpression';
         node.properties.forEach((property) => {
-          if (property.type === 'Property' && (property.key.type === 'PrivateIdentifier' || property.key.type === 'Identifier') && property.key.name === 'state' && isDerivedFromThis) {
+          if (property.type === 'Property' && property.key.type === 'Identifier' && property.key.name === 'state' && isDerivedFromThis) {
             vars.push({
               node: property.key,
               scope: context.getScope(),

lib/rules/no-children-prop.js

@@ -89,10 +89,10 @@ module.exports = {
 
         const props = node.arguments[1].properties;
         const childrenProp = props.find(
-          (prop) => prop.type === 'Property' && (prop.key.type === 'PrivateIdentifier' || prop.key.type === 'Identifier') && prop.key.name === 'children'
+          (prop) => prop.type === 'Property' && prop.key.type === 'Identifier' && prop.key.name === 'children'
         );
 
-        if (childrenProp.type === 'Property') {
+        if (childrenProp && childrenProp.type === 'Property') {
           if (childrenProp.value && !isFunction(childrenProp.value)) {
             report(context, messages.passChildrenAsArgs, 'passChildrenAsArgs', {
               node,

lib/rules/sort-default-props.js

@@ -164,7 +164,9 @@ module.exports = {
       },
 
       MemberExpression(node) {
-        if (!isDefaultPropsDeclaration(node) || node.parent.type !== 'BinaryExpression') {
+        if (
+          !isDefaultPropsDeclaration(node)
+          || (node.parent.type !== 'BinaryExpression' && node.parent.type !== 'AssignmentExpression' && node.parent.type !== 'LogicalExpression' && node.parent.type !== 'AssignmentPattern')) {
           return;
         }
 

lib/rules/style-prop-object.js

@@ -92,11 +92,10 @@ module.exports = {
             }
           }
           if (node.arguments[1].type === 'ObjectExpression') {
-            const style = node.arguments[1].properties.find((property) => property.type === 'Property' && property.key.type === 'Identifier' && property.key.name === 'style' && !property.computed);
-            if (style.type !== 'Property') {
-              return;
-            }
-            if (style) {
+            const style = node.arguments[1].properties.find(
+              (property) => property.type === 'Property' && property.key.type === 'Identifier' && property.key.name === 'style' && !property.computed
+            );
+            if (style && style.type === 'Property') {
               if (style.value.type === 'Identifier') {
                 checkIdentifiers(style.value);
               } else if (isNonNullaryLiteral(style.value)) {