Skip to content

Commit 1818e01

Browse files
committed
Add React.createClass to no-deprecated
1 parent 0ae6bb2 commit 1818e01

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/rules/no-deprecated.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ module.exports = {
6464
deprecated.MemberExpression['Perf.printDOM'] = ['15.0.0', 'Perf.printOperations'];
6565
deprecated.MemberExpression['ReactPerf.getMeasurementsSummaryMap'] = ['15.0.0', 'ReactPerf.getWasted'];
6666
deprecated.MemberExpression['Perf.getMeasurementsSummaryMap'] = ['15.0.0', 'Perf.getWasted'];
67+
// 15.5.0
68+
deprecated.MemberExpression['React.createClass'] = ['15.5.0', 'the npm module create-react-class'];
6769

6870
return deprecated;
6971
}

tests/lib/rules/no-deprecated.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ ruleTester.run('no-deprecated', rule, {
2323

2424
valid: [
2525
// Not deprecated
26-
'var MyClass = React.createClass({});',
2726
'var element = React.createElement(\'p\', {}, null);',
2827
'var clone = React.cloneElement(element);',
2928
'ReactDOM.render(element, container);',
@@ -94,6 +93,11 @@ ruleTester.run('no-deprecated', rule, {
9493
'use ReactDOMServer.renderToStaticMarkup instead'
9594
)
9695
}]
96+
}, {
97+
code: 'React.createClass({});',
98+
errors: [{
99+
message: 'React.createClass is deprecated since React 15.5.0, use the npm module create-react-class instead'
100+
}]
97101
}]
98102

99103
});

0 commit comments

Comments
 (0)