fix sibling reporting

Author: TSMMark

lib/rules/jsx-one-element-per-line.js

@@ -38,7 +38,6 @@ module.exports = {
         }
 
         const openingElementEndLine = node.loc.end.line;
-        const openingElementEndColumn = node.loc.end.column;
 
         // Children
         if (node.parent.children.length) {
@@ -67,30 +66,16 @@ module.exports = {
 
         // Siblings
         if (node.parent.parent && node.parent.parent.children && node.parent.parent.children.length) {
-          const siblingsOnLine = [];
-          node.parent.parent.children.forEach(childNode => {
-            if (
-              node.parent === childNode ||
-              !childNode.openingElement ||
-              childNode.openingElement.loc.start.line !== openingElementEndLine ||
-              childNode.openingElement.loc.start.column < openingElementEndColumn
-            ) {
-              return;
-            }
+          const firstSibling = node.parent.parent.children.find(sibling => sibling.type === 'JSXElement');
 
-            siblingsOnLine.push(childNode);
-          });
-
-          if (!siblingsOnLine.length) {
+          if (firstSibling === node.parent) {
             return;
           }
 
-          siblingsOnLine.forEach(elementInLine => {
-            context.report({
-              node: elementInLine,
-              message: `Opening tag for Element \`${elementInLine.openingElement.name.name}\` must be placed on a new line`,
-              fix: generateFixFunction(elementInLine)
-            });
+          context.report({
+            node: node,
+            message: `Opening tag for Element \`${node.name.name}\` must be placed on a new line`,
+            fix: generateFixFunction(node)
           });
         }
       },

tests/lib/rules/jsx-one-element-per-line.js

@@ -242,5 +242,21 @@ ruleTester.run('jsx-max-elements-per-line', rule, {
     ].join('\n'),
     errors: [{message: 'Closing tag for Element `App` must be placed on a new line'}],
     parserOptions: parserOptions
+  }, {
+    code: [
+      '<App>',
+      '  <Foo></',
+      'Foo><Bar />',
+      '</App>'
+    ].join('\n'),
+    output: [
+      '<App>',
+      '  <Foo></',
+      'Foo>',
+      '<Bar />',
+      '</App>'
+    ].join('\n'),
+    errors: [{message: 'Opening tag for Element `Bar` must be placed on a new line'}],
+    parserOptions: parserOptions
   }]
 });