Skip to content

Commit 330368b

Browse files
committed
Rewrite jsx-handler-names tests with template literals
1 parent 016f2be commit 330368b

File tree

1 file changed

+21
-63
lines changed

1 file changed

+21
-63
lines changed

tests/lib/rules/jsx-handler-names.js

Lines changed: 21 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -27,105 +27,63 @@ const parserOptions = {
2727
const ruleTester = new RuleTester({parserOptions});
2828
ruleTester.run('jsx-handler-names', rule, {
2929
valid: [{
30-
code: [
31-
'<TestComponent onChange={this.handleChange} />'
32-
].join('\n')
30+
code: '<TestComponent onChange={this.handleChange} />'
3331
}, {
34-
code: [
35-
'<TestComponent onChange={this.props.onChange} />'
36-
].join('\n')
32+
code: '<TestComponent onChange={this.props.onChange} />'
3733
}, {
38-
code: [
39-
'<TestComponent onChange={this.props.onFoo} />'
40-
].join('\n')
34+
code: '<TestComponent onChange={this.props.onFoo} />'
4135
}, {
42-
code: [
43-
'<TestComponent isSelected={this.props.isSelected} />'
44-
].join('\n')
36+
code: '<TestComponent isSelected={this.props.isSelected} />'
4537
}, {
46-
code: [
47-
'<TestComponent shouldDisplay={this.state.shouldDisplay} />'
48-
].join('\n')
38+
code: '<TestComponent shouldDisplay={this.state.shouldDisplay} />'
4939
}, {
50-
code: [
51-
'<TestComponent shouldDisplay={arr[0].prop} />'
52-
].join('\n')
40+
code: '<TestComponent shouldDisplay={arr[0].prop} />'
5341
}, {
54-
code: [
55-
'<TestComponent onChange={props.onChange} />'
56-
].join('\n')
42+
code: '<TestComponent onChange={props.onChange} />'
5743
}, {
58-
code: [
59-
'<TestComponent ref={this.handleRef} />'
60-
].join('\n')
44+
code: '<TestComponent ref={this.handleRef} />'
6145
}, {
62-
code: [
63-
'<TestComponent ref={this.somethingRef} />'
64-
].join('\n')
46+
code: '<TestComponent ref={this.somethingRef} />'
6547
}, {
66-
code: [
67-
'<TestComponent test={this.props.content} />'
68-
].join('\n'),
48+
code: '<TestComponent test={this.props.content} />',
6949
options: [{
7050
eventHandlerPrefix: 'on',
7151
eventHandlerPropPrefix: 'on'
7252
}]
7353
}, {
74-
code: [
75-
'<TestComponent onChange={props::handleChange} />'
76-
].join('\n'),
54+
code: '<TestComponent onChange={props::handleChange} />',
7755
parser: 'babel-eslint'
7856
}, {
79-
code: [
80-
'<TestComponent onChange={::props.onChange} />'
81-
].join('\n'),
57+
code: '<TestComponent onChange={::props.onChange} />',
8258
parser: 'babel-eslint'
8359
}, {
84-
code: [
85-
'<TestComponent onChange={props.foo::handleChange} />'
86-
].join('\n'),
60+
code: '<TestComponent onChange={props.foo::handleChange} />',
8761
parser: 'babel-eslint'
8862
}, {
89-
code: [
90-
'<TestComponent only={this.only} />'
91-
].join('\n')
63+
code: '<TestComponent only={this.only} />'
9264
}],
9365

9466
invalid: [{
95-
code: [
96-
'<TestComponent onChange={this.doSomethingOnChange} />'
97-
].join('\n'),
67+
code: '<TestComponent onChange={this.doSomethingOnChange} />',
9868
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
9969
}, {
100-
code: [
101-
'<TestComponent onChange={this.handlerChange} />'
102-
].join('\n'),
70+
code: '<TestComponent onChange={this.handlerChange} />',
10371
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
10472
}, {
105-
code: [
106-
'<TestComponent only={this.handleChange} />'
107-
].join('\n'),
73+
code: '<TestComponent only={this.handleChange} />',
10874
errors: [{message: 'Prop key for handleChange must begin with \'on\''}]
10975
}, {
110-
code: [
111-
'<TestComponent handleChange={this.handleChange} />'
112-
].join('\n'),
76+
code: '<TestComponent handleChange={this.handleChange} />',
11377
errors: [{message: 'Prop key for handleChange must begin with \'on\''}]
11478
}, {
115-
code: [
116-
'<TestComponent onChange={this.onChange} />'
117-
].join('\n'),
79+
code: '<TestComponent onChange={this.onChange} />',
11880
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
11981
}, {
120-
code: [
121-
'<TestComponent onChange={props::onChange} />'
122-
].join('\n'),
82+
code: '<TestComponent onChange={props::onChange} />',
12383
parser: 'babel-eslint',
12484
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
12585
}, {
126-
code: [
127-
'<TestComponent onChange={props.foo::onChange} />'
128-
].join('\n'),
86+
code: '<TestComponent onChange={props.foo::onChange} />',
12987
parser: 'babel-eslint',
13088
errors: [{message: 'Handler function for onChange prop key must begin with \'handle\''}]
13189
}]

0 commit comments

Comments
 (0)