Skip to content

Commit 3da1140

Browse files
committed
Use pragma option & add more specs
1 parent 269bffd commit 3da1140

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

lib/rules/no-deprecated.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ module.exports = {
6565
deprecated.MemberExpression['ReactPerf.getMeasurementsSummaryMap'] = ['15.0.0', 'ReactPerf.getWasted'];
6666
deprecated.MemberExpression['Perf.getMeasurementsSummaryMap'] = ['15.0.0', 'Perf.getWasted'];
6767
// 15.5.0
68-
deprecated.MemberExpression['React.createClass'] = ['15.5.0', 'the npm module create-react-class'];
69-
deprecated.MemberExpression['React.PropTypes'] = ['15.5.0', 'the npm module prop-types'];
68+
deprecated.MemberExpression[pragma + '.createClass'] = ['15.5.0', 'the npm module create-react-class'];
69+
deprecated.MemberExpression[pragma + '.PropTypes'] = ['15.5.0', 'the npm module prop-types'];
7070

7171
return deprecated;
7272
}

tests/lib/rules/no-deprecated.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ ruleTester.run('no-deprecated', rule, {
3131
'ReactDOMServer.renderToString(element);',
3232
'ReactDOMServer.renderToStaticMarkup(element);',
3333
// Deprecated in a later version
34-
{code: 'React.renderComponent()', settings: {react: {version: '0.11.0'}}}
34+
{code: 'React.renderComponent()', settings: {react: {version: '0.11.0'}}},
35+
{code: 'React.createClass()', settings: {react: {version: '15.4.0'}}},
36+
{code: 'React.PropTypes', settings: {react: {version: '15.4.0'}}}
3537
],
3638

3739
invalid: [{
@@ -98,6 +100,12 @@ ruleTester.run('no-deprecated', rule, {
98100
errors: [{
99101
message: 'React.createClass is deprecated since React 15.5.0, use the npm module create-react-class instead'
100102
}]
103+
}, {
104+
code: 'Foo.createClass({});',
105+
settings: {react: {pragma: 'Foo'}},
106+
errors: [{
107+
message: 'Foo.createClass is deprecated since React 15.5.0, use the npm module create-react-class instead'
108+
}]
101109
}, {
102110
code: 'React.PropTypes',
103111
errors: [{

0 commit comments

Comments
 (0)