Skip to content

Commit 42cfd68

Browse files
committed
Fix external propTypes handling (fixes #545)
1 parent 3187bf9 commit 42cfd68

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

lib/rules/prop-types.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,8 @@ module.exports = Components.detect(function(context, components, utils) {
661661
if (propTypes && propTypes.parent && propTypes.property) {
662662
curDeclaredPropTypes[propTypes.property.name] =
663663
buildReactDeclarationTypes(propTypes.parent.right);
664+
} else {
665+
ignorePropsValidation = true;
664666
}
665667
break;
666668
case 'Identifier':

tests/lib/rules/prop-types.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,16 @@ ruleTester.run('prop-types', rule, {
110110
'});'
111111
].join('\n'),
112112
parserOptions: parserOptions
113+
}, {
114+
code: [
115+
'var Hello = React.createClass({',
116+
' propTypes: externalPropTypes.mySharedPropTypes,',
117+
' render: function() {',
118+
' return <div>Hello {this.props.name}</div>;',
119+
' }',
120+
'});'
121+
].join('\n'),
122+
parserOptions: parserOptions
113123
}, {
114124
code: [
115125
'class Hello extends React.Component {',

0 commit comments

Comments
 (0)