Skip to content

Commit 466bb5e

Browse files
committed
Fix require-render-return crash (fixes #784)
1 parent 7024678 commit 466bb5e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

lib/rules/require-render-return.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ module.exports = {
7373
function hasRenderMethod(node) {
7474
var properties = getComponentProperties(node);
7575
for (var i = 0, j = properties.length; i < j; i++) {
76-
if (getPropertyName(properties[i]) !== 'render') {
76+
if (getPropertyName(properties[i]) !== 'render' || !properties[i].value) {
7777
continue;
7878
}
7979
return /FunctionExpression$/.test(properties[i].value.type);

tests/lib/rules/require-render-return.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,14 @@ ruleTester.run('require-render-return', rule, {
141141
'});'
142142
].join('\n'),
143143
parserOptions: parserOptions
144+
}, {
145+
// Invalid render method (but accepted by Babel)
146+
code: [
147+
'class Foo extends Component {',
148+
' render',
149+
'}'
150+
].join('\n'),
151+
parser: 'babel-eslint'
144152
}],
145153

146154
invalid: [{

0 commit comments

Comments
 (0)