Skip to content

Commit 4a292d1

Browse files
committed
fix detect missing displayName in React class when ecmaFeatures.jsx is false
1 parent c0ed5fc commit 4a292d1

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

lib/rules/display-name.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,12 @@ module.exports = function(context) {
117117
}
118118
markDisplayNameAsDeclared(node);
119119
});
120+
121+
if (componentUtil.isComponentDefinition(node)) {
122+
componentList.set(context, node, {
123+
isReactComponent: true
124+
});
125+
}
120126
},
121127

122128
'Program:exit': function() {

tests/lib/rules/display-name.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,20 @@ eslintTester.addRuleTest('lib/rules/display-name', {
8989
}],
9090

9191
invalid: [{
92+
code: [
93+
'var Hello = React.createClass({',
94+
' render: function() {',
95+
' return React.createElement("div", {}, "text content");',
96+
' }',
97+
'});'
98+
].join('\n'),
99+
ecmaFeatures: {
100+
jsx: false
101+
},
102+
errors: [{
103+
message: 'Component definition is missing display name'
104+
}]
105+
}, {
92106
code: [
93107
'var Hello = React.createClass({',
94108
' render: function() {',

0 commit comments

Comments
 (0)