refactor rule to simply check parent line instead of all children

Author: TSMMark

lib/rules/jsx-one-element-per-line.js

@@ -37,48 +37,32 @@ module.exports = {
           return;
         }
 
-        const openingElementEndLine = node.loc.end.line;
+        const openingStartLine = node.loc.start.line;
 
-        // TODO: Just check if my parent opening tag is on the same line as me.
+        // Parent
+        if (node.parent.parent && node.parent.parent.openingElement) {
+          const parentOpeningStartLine = node.parent.parent.openingElement.loc.end.line;
 
-        // Children
-        if (node.parent.children.length) {
-          const childrenOnLine = [];
-
-          node.parent.children.forEach(childNode => {
-            if (!childNode.openingElement || childNode.openingElement.loc.start.line !== openingElementEndLine) {
-              return;
-            }
-
-            childrenOnLine.push(childNode);
-          });
-
-          if (!childrenOnLine.length) {
-            return;
-          }
-
-          childrenOnLine.forEach(childOnLine => {
+          if (parentOpeningStartLine === openingStartLine) {
             context.report({
-              node: childOnLine,
-              message: `Opening tag for Element \`${childOnLine.openingElement.name.name}\` must be placed on a new line`,
-              fix: generateFixFunction(childOnLine)
+              node: node,
+              message: `Opening tag for Element \`${node.name.name}\` must be placed on a new line`,
+              fix: generateFixFunction(node)
             });
-          });
+          }
         }
 
         // Siblings
         if (node.parent.parent && node.parent.parent.children && node.parent.parent.children.length) {
           const firstSibling = node.parent.parent.children.find(sibling => sibling.type === 'JSXElement');
 
-          if (firstSibling === node.parent) {
-            return;
+          if (firstSibling !== node.parent) {
+            context.report({
+              node: node,
+              message: `Opening tag for Element \`${node.name.name}\` must be placed on a new line`,
+              fix: generateFixFunction(node)
+            });
           }
-
-          context.report({
-            node: node,
-            message: `Opening tag for Element \`${node.name.name}\` must be placed on a new line`,
-            fix: generateFixFunction(node)
-          });
         }
       },