Adjsut schema

Author: Pearce-Ropion

docs/rules/jsx-no-literals.md

@@ -34,6 +34,7 @@ The supported options are:
 - `allowedStrings` - An array of unique string values that would otherwise warn, but will be ignored.
 - `ignoreProps` (default: `false`) - When `true` the rule ignores literals used in props, wrapped or unwrapped.
 - `noAttributeStrings` (default: `false`) - Enforces no string literals used in attributes when set to `true`.
+- `elementOverrides` - An object where the keys are the element names and the values are objects with the same options as above. This allows you to specify different options for different elements.
 
 To use, you can specify as follows:
 

lib/rules/jsx-no-literals.js

@@ -25,7 +25,28 @@ const messages = {
   invalidPropValue: 'Invalid prop value: "{{text}}"',
   noStringsInAttributes: 'Strings not allowed in attributes: "{{text}}"',
   noStringsInJSX: 'Strings not allowed in JSX files: "{{text}}"',
-  literalNotInJSXExpression: 'Missing JSX expression container around literal string: "{{text}}"',
+  literalNotInJSXExpression:
+    'Missing JSX expression container around literal string: "{{text}}"',
+};
+
+/** @type {import('json-schema').JSONSchema4['properties']} */
+const elementSchemaProperties = {
+  noStrings: {
+    type: 'boolean',
+  },
+  allowedStrings: {
+    type: 'array',
+    uniqueItems: true,
+    items: {
+      type: 'string',
+    },
+  },
+  ignoreProps: {
+    type: 'boolean',
+  },
+  noAttributeStrings: {
+    type: 'boolean',
+  },
 };
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -40,28 +61,21 @@ module.exports = {
 
     messages,
 
-    schema: [{
-      type: 'object',
-      properties: {
-        noStrings: {
-          type: 'boolean',
-        },
-        allowedStrings: {
-          type: 'array',
-          uniqueItems: true,
-          items: {
-            type: 'string',
+    schema: [
+      {
+        type: 'object',
+        properties: Object.assign(
+          {
+            elementOverrides: {
+              type: 'object',
+              properties: elementSchemaProperties,
+            },
           },
-        },
-        ignoreProps: {
-          type: 'boolean',
-        },
-        noAttributeStrings: {
-          type: 'boolean',
-        },
+          elementSchemaProperties
+        ),
+        additionalProperties: false,
       },
-      additionalProperties: false,
-    }],
+    ],
   },
 
   create(context) {
@@ -72,7 +86,9 @@ module.exports = {
       noAttributeStrings: false,
     };
     const config = Object.assign({}, defaults, context.options[0] || {});
-    config.allowedStrings = new Set(map(iterFrom(config.allowedStrings), trimIfString));
+    config.allowedStrings = new Set(
+      map(iterFrom(config.allowedStrings), trimIfString)
+    );
 
     function defaultMessageId(ancestorIsJSXElement) {
       if (config.noAttributeStrings && !ancestorIsJSXElement) {
@@ -101,9 +117,15 @@ module.exports = {
       const parent = getParentIgnoringBinaryExpressions(node);
 
       function isParentNodeStandard() {
-        if (!/^[\s]+$/.test(node.value) && typeof node.value === 'string' && parent.type.includes('JSX')) {
+        if (
+          !/^[\s]+$/.test(node.value) &&
+          typeof node.value === 'string' &&
+          parent.type.includes('JSX')
+        ) {
           if (config.noAttributeStrings) {
-            return parent.type === 'JSXAttribute' || parent.type === 'JSXElement';
+            return (
+              parent.type === 'JSXAttribute' || parent.type === 'JSXElement'
+            );
           }
           if (!config.noAttributeStrings) {
             return parent.type !== 'JSXAttribute';
@@ -139,7 +161,11 @@ module.exports = {
       const parentType = parents.parentType;
       const grandParentType = parents.grandParentType;
 
-      return parentType === 'JSXFragment' || parentType === 'JSXElement' || grandParentType === 'JSXElement';
+      return (
+        parentType === 'JSXFragment' ||
+        parentType === 'JSXElement' ||
+        grandParentType === 'JSXElement'
+      );
     }
 
     function reportLiteralNode(node, messageId) {
@@ -160,13 +186,21 @@ module.exports = {
 
     return {
       Literal(node) {
-        if (getValidation(node) && (hasJSXElementParentOrGrandParent(node) || !config.ignoreProps)) {
+        if (
+          getValidation(node) &&
+          (hasJSXElementParentOrGrandParent(node) || !config.ignoreProps)
+        ) {
           reportLiteralNode(node);
         }
       },
 
       JSXAttribute(node) {
-        const isNodeValueString = node && node.value && node.value.type === 'Literal' && typeof node.value.value === 'string' && !config.allowedStrings.has(node.value.value);
+        const isNodeValueString =
+          node &&
+          node.value &&
+          node.value.type === 'Literal' &&
+          typeof node.value.value === 'string' &&
+          !config.allowedStrings.has(node.value.value);
 
         if (config.noStrings && !config.ignoreProps && isNodeValueString) {
           const messageId = 'invalidPropValue';
@@ -184,10 +218,16 @@ module.exports = {
         const parents = getParentAndGrandParentType(node);
         const parentType = parents.parentType;
         const grandParentType = parents.grandParentType;
-        const isParentJSXExpressionCont = parentType === 'JSXExpressionContainer';
-        const isParentJSXElement = parentType === 'JSXElement' || grandParentType === 'JSXElement';
-
-        if (isParentJSXExpressionCont && config.noStrings && (isParentJSXElement || !config.ignoreProps)) {
+        const isParentJSXExpressionCont =
+          parentType === 'JSXExpressionContainer';
+        const isParentJSXElement =
+          parentType === 'JSXElement' || grandParentType === 'JSXElement';
+
+        if (
+          isParentJSXExpressionCont &&
+          config.noStrings &&
+          (isParentJSXElement || !config.ignoreProps)
+        ) {
           reportLiteralNode(node);
         }
       },