Merge pull request #260 from gaearon/prop-types-false-positive

Failing test case for using this.props in constructor

Author: yannickcr

tests/lib/rules/prop-types.js

@@ -795,6 +795,19 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  constructor(props, context) {',
+        '    super(props, context)',
+        '    this.state = { status: this.props.source.uri }',
+        '  }',
+        '  static propTypes = {',
+        '    source: PropTypes.object',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }, {
       // Should not be detected as a component
       code: [
@@ -1286,6 +1299,33 @@ ruleTester.run('prop-types', rule, {
         {message: '\'source\' is missing in props validation for Hello'},
         {message: '\'source.uri\' is missing in props validation for Hello'}
       ]
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  constructor(props, context) {',
+        '    super(props, context)',
+        '    this.state = { status: this.props.source }',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [
+        {message: '\'source\' is missing in props validation for Hello'}
+      ]
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  constructor(props, context) {',
+        '    super(props, context)',
+        '    this.state = { status: this.props.source.uri }',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [
+        {message: '\'source\' is missing in props validation for Hello'},
+        {message: '\'source.uri\' is missing in props validation for Hello'}
+      ]
     }
   ]
 });