Skip to content

Commit 81c7d00

Browse files
committed
Fix prop-types to not validate computed keys in destructuring (fixes #236)
1 parent a0d55ed commit 81c7d00

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/rules/prop-types.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ module.exports = function(context) {
405405
break;
406406
case 'destructuring':
407407
for (var k = 0, l = properties.length; k < l; k++) {
408-
if (hasSpreadOperator(properties[k])) {
408+
if (hasSpreadOperator(properties[k]) || properties[k].computed) {
409409
continue;
410410
}
411411
var propName = getKeyValue(properties[k]);

tests/lib/rules/prop-types.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,17 @@ ruleTester.run('prop-types', rule, {
771771
ecmaFeatures: {
772772
jsx: true
773773
}
774+
}, {
775+
code: [
776+
'class Hello extends React.Component {',
777+
' render() {',
778+
' var foo = \'fullname\';',
779+
' var { [foo]: firstname } = this.props;',
780+
' return <div>Hello {firstname}</div>;',
781+
' }',
782+
'}'
783+
].join('\n'),
784+
parser: 'babel-eslint'
774785
}
775786
],
776787

0 commit comments

Comments
 (0)