Fix proptypes detection for nested classes (fixes #267)

Author: yannickcr

lib/util/component.js

@@ -75,7 +75,7 @@ function getIdentifiers(node) {
   var name = [];
   var loopNode = node;
   var namePart;
-  while (loopNode && (!name.length || loopNode.type !== 'FunctionDeclaration')) {
+  while (loopNode && (!name.length || ['FunctionDeclaration', 'MethodDefinition'].indexOf(loopNode.type) === -1)) {
     namePart = (loopNode.id && loopNode.id.name) || (loopNode.key && loopNode.key.name);
     if (namePart) {
       name.unshift(namePart);

tests/lib/rules/prop-types.js

@@ -846,6 +846,29 @@ ruleTester.run('prop-types', rule, {
         'module.exports = HelloComponent();'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'class DynamicHello extends Component {',
+        '  render() {',
+        '    const {firstname} = this.props;',
+        '    class Hello extends Component {',
+        '      render() {',
+        '        const {name} = this.props;',
+        '        return <div>Hello {name}</div>;',
+        '      }',
+        '    }',
+        '    Hello.propTypes = {',
+        '      name: PropTypes.string',
+        '    };',
+        '    Hello = connectReduxForm({name: firstname})(Hello);',
+        '    return <Hello />;',
+        '  }',
+        '}',
+        'DynamicHello.propTypes = {',
+        '  firstname: PropTypes.string,',
+        '};'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],
 
@@ -1386,6 +1409,27 @@ ruleTester.run('prop-types', rule, {
       errors: [
         {message: '\'name\' is missing in props validation for Hello'}
       ]
+    }, {
+      code: [
+        'class DynamicHello extends Component {',
+        '  render() {',
+        '    const {firstname} = this.props;',
+        '    class Hello extends Component {',
+        '      render() {',
+        '        const {name} = this.props;',
+        '        return <div>Hello {name}</div>;',
+        '      }',
+        '    }',
+        '    Hello = connectReduxForm({name: firstname})(Hello);',
+        '    return <Hello />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [
+        {message: '\'firstname\' is missing in props validation for DynamicHello'},
+        {message: '\'name\' is missing in props validation for Hello'}
+      ]
     }
   ]
 });