Bail out for line-breakers in JSX

Author: jackyho112

lib/rules/jsx-curly-brace-presence.js

@@ -59,6 +59,10 @@ module.exports = {
       {props: ruleOptions, children: ruleOptions} :
       Object.assign({}, DEFAULT_CONFIG, ruleOptions);
 
+    function containsLineTerminators(rawStringValue) {
+      return /[\n\r\u2028\u2029]+/.test(rawStringValue);
+    }
+
     function containsBackslash(rawStringValue) {
       return rawStringValue.includes('\\');
     }
@@ -125,9 +129,13 @@ module.exports = {
         node: literalNode,
         message: 'Need to wrap this literal in a JSX expression.',
         fix: function(fixer) {
-          // Leave it to the author to fix as it can be fixed by either a
-          // real character or unicode
-          if (containsHTMLEntity(literalNode.raw)) {
+          // If a HTML entity name is found, bail out because it can be fixed
+          // by either using the real character or the unicode equivalent.
+          // If it contains any line terminator character, bail out as well.
+          if (
+            containsHTMLEntity(literalNode.raw) ||
+            containsLineTerminators(literalNode.raw)
+          ) {
             return null;
           }
 

tests/lib/rules/jsx-curly-brace-presence.js

@@ -411,13 +411,6 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
         '         d      ',
         '</App>'
       ].join('\n'),
-      output: [
-        '<App prop={"    ',
-        '   a     ',
-        '     b      c',
-        '        d',
-        '"}>{"\\n  a\\n      b     c   \\n         d      \\n"}</App>'
-      ].join('\n'),
       errors: [
         {message: missingCurlyMessage}, {message: missingCurlyMessage}
       ],
@@ -435,13 +428,6 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
         '         d      ',
         '</App>'
       ].join('\n'),
-      output: [
-        '<App prop={"    ',
-        '   a     ',
-        '     b      c',
-        '        d',
-        '"}>{"\\n  a\\n      b     c   \\n         d      \\n"}</App>'
-      ].join('\n'),
       errors: [
         {message: missingCurlyMessage}, {message: missingCurlyMessage}
       ],