fix always reporting new line required for all siblings

Author: TSMMark

lib/rules/jsx-one-element-per-line.js

@@ -31,6 +31,23 @@ module.exports = {
       };
     }
 
+    function elementDoesOpenOrCloseOnLine (element, line) {
+      const reportableLines = [element.openingElement, element.closingElement].reduce((lines, el) => {
+        if (!el) {
+          return lines;
+        }
+
+        return lines.concat([el.loc.start.line, el.loc.end.line]);
+      }, []);
+
+
+      return reportableLines.indexOf(line) !== -1;
+    }
+
+    function anyElementDoesOpenOrCloseOnLine (elements, line) {
+      return elements.some(element => elementDoesOpenOrCloseOnLine(element, line));
+    }
+
     return {
       JSXOpeningElement: function (node) {
         if (!node.parent) {
@@ -54,9 +71,11 @@ module.exports = {
 
         // Siblings
         if (node.parent.parent && node.parent.parent.children && node.parent.parent.children.length) {
-          const firstSibling = node.parent.parent.children.find(sibling => sibling.type === 'JSXElement');
+          const firstSiblingOnLine = node.parent.parent.children.find(sibling => (
+            sibling.type === 'JSXElement' && elementDoesOpenOrCloseOnLine(sibling, openingStartLine)
+          ));
 
-          if (firstSibling !== node.parent) {
+          if (firstSiblingOnLine !== node.parent) {
             context.report({
               node: node,
               message: `Opening tag for Element \`${node.name.name}\` must be placed on a new line`,
@@ -73,20 +92,7 @@ module.exports = {
 
         const closingElementStartLine = node.loc.end.line;
 
-        const anyChildrenOnLine = node.parent.children.some(child => {
-          const reportableLines = [child.openingElement, child.closingElement].reduce((lines, el) => {
-            if (!el) {
-              return lines;
-            }
-
-            return lines.concat([el.loc.start.line, el.loc.end.line]);
-          }, []);
-
-
-          return reportableLines.indexOf(closingElementStartLine) !== -1;
-        });
-
-        if (!anyChildrenOnLine) {
+        if (!anyElementDoesOpenOrCloseOnLine(node.parent.children, closingElementStartLine)) {
           return;
         }
 

tests/lib/rules/jsx-one-element-per-line.js

@@ -43,6 +43,13 @@ ruleTester.run('jsx-max-elements-per-line', rule, {
       '  <Foo />',
       '</App>'
     ].join('\n')
+  }, {
+    code: [
+      '<App>',
+      '  <Foo />',
+      '  <Bar />',
+      '</App>'
+    ].join('\n')
   }, {
     code: [
       '<App>',