Skip to content

Commit 8fe83a0

Browse files
committed
Only ignore lowercase JSXIdentifier in jsx-no-undef (fixes #435)
1 parent b524868 commit 8fe83a0

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

lib/rules/jsx-no-undef.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ module.exports = function(context) {
5858
switch (node.name.type) {
5959
case 'JSXIdentifier':
6060
node = node.name;
61+
if (isTagName(node.name)) {
62+
return;
63+
}
6164
break;
6265
case 'JSXMemberExpression':
6366
node = node.name.object;
@@ -68,9 +71,6 @@ module.exports = function(context) {
6871
default:
6972
break;
7073
}
71-
if (isTagName(node.name)) {
72-
return;
73-
}
7474
checkIdentifierInJSX(node);
7575
}
7676
};

tests/lib/rules/jsx-no-undef.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,17 @@ ruleTester.run('jsx-no-undef', rule, {
5252
message: '\'Appp\' is not defined.'
5353
}],
5454
parserOptions: parserOptions
55-
},
56-
{
55+
}, {
5756
code: '/*eslint no-undef:1*/ var React; React.render(<Apppp:Foo />);',
5857
errors: [{
5958
message: '\'Apppp\' is not defined.'
6059
}],
6160
parserOptions: parserOptions
61+
}, {
62+
code: '/*eslint no-undef:1*/ var React; React.render(<appp.Foo />);',
63+
errors: [{
64+
message: '\'appp\' is not defined.'
65+
}],
66+
parserOptions: parserOptions
6267
}]
6368
});

0 commit comments

Comments
 (0)