Update no-unused-prop-types rule for new React class component lifecycles

Author: bvaughn

lib/rules/no-unused-prop-types.js

@@ -22,7 +22,15 @@ const docsUrl = require('../util/docsUrl');
 const DIRECT_PROPS_REGEX = /^props\s*(\.|\[)/;
 const DIRECT_NEXT_PROPS_REGEX = /^nextProps\s*(\.|\[)/;
 const DIRECT_PREV_PROPS_REGEX = /^prevProps\s*(\.|\[)/;
-const LIFE_CYCLE_METHODS = ['componentWillReceiveProps', 'shouldComponentUpdate', 'componentWillUpdate', 'componentDidUpdate'];
+const LIFE_CYCLE_METHODS = [
+  'componentDidUpdate',
+  'componentWillReceiveProps',
+  'componentWillUpdate',
+  'getDerivedStateFromProps',
+  'shouldComponentUpdate',
+  'UNSAFE_componentWillReceiveProps',
+  'UNSAFE_componentWillUpdate'
+];
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -252,10 +260,7 @@ module.exports = {
       const nodeKeyName = (node.key || {}).name;
       return (
         node.kind === 'constructor' ||
-        nodeKeyName === 'componentWillReceiveProps' ||
-        nodeKeyName === 'shouldComponentUpdate' ||
-        nodeKeyName === 'componentWillUpdate' ||
-        nodeKeyName === 'componentDidUpdate'
+        LIFE_CYCLE_METHODS.indexOf(nodeKeyName) >= 0
       );
     }
 

tests/lib/rules/no-unused-prop-types.js

@@ -2825,6 +2825,58 @@ ruleTester.run('no-unused-prop-types', rule, {
         }
         MyComponent.propTypes = { * other() {} };
       `
+    }, {
+      // Sanity test coverage for new UNSAFE_componentWillReceiveProps lifecycles
+      code: [`
+        class Hello extends Component {
+          static propTypes = {
+            something: PropTypes.bool
+          };
+          UNSAFE_componentWillReceiveProps (nextProps) {
+            const {something} = nextProps;
+            doSomething(something);
+          }
+        }
+      `].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      // Destructured props in the `UNSAFE_componentWillUpdate` method shouldn't throw errors
+      code: [`
+        class Hello extends Component {
+          static propTypes = {
+            something: PropTypes.bool
+          };
+          UNSAFE_componentWillUpdate (nextProps, nextState) {
+            const {something} = nextProps;
+            return something;
+          }
+        }
+      `].join('\n'),
+      parser: 'babel-eslint'
+    }, {
+      // Simple test of new static getDerivedStateFromProps lifecycle
+      code: [`
+        class MyComponent extends React.Component {
+          static propTypes = {
+            defaultValue: 'bar'
+          };
+          state = {
+            currentValue: null
+          };
+          static getDerivedStateFromProps(nextProps, prevState) {
+            if (prevState.currentValue === null) {
+              return {
+                currentValue: nextProps.defaultValue,
+              }
+            }
+            return null;
+          }
+          render() {
+            return <div>{ this.state.currentValue }</div>
+          }
+        }
+      `].join('\n'),
+      parser: 'babel-eslint'
     }
   ],