Skip to content

Commit 999e7c4

Browse files
committed
Fix "ignore" option for prop-types rule (fixes #135)
1 parent e577f76 commit 999e7c4

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

lib/rules/prop-types.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,12 +500,11 @@ module.exports = function(context) {
500500
* @param {Object} component The component to process
501501
*/
502502
function reportUndeclaredPropTypes(component) {
503-
var allNames, name;
503+
var allNames;
504504
for (var i = 0, j = component.usedPropTypes.length; i < j; i++) {
505-
name = component.usedPropTypes[i].name;
506505
allNames = component.usedPropTypes[i].allNames;
507506
if (
508-
isIgnored(name) ||
507+
isIgnored(allNames[0]) ||
509508
isDeclaredInComponent(component, allNames)
510509
) {
511510
continue;

tests/lib/rules/prop-types.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,16 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
512512
classes: true,
513513
jsx: true
514514
}
515+
}, {
516+
code: [
517+
'class Hello extends React.Component {',
518+
' render() {',
519+
' return <div>{this.props.name.firstname}</div>;',
520+
' }',
521+
'}'
522+
].join('\n'),
523+
parser: 'babel-eslint',
524+
args: [1, {ignore: ['name']}]
515525
}
516526
],
517527

0 commit comments

Comments
 (0)