Skip to content

Commit c4fcff9

Browse files
HenryBrown0ljharb
authored andcommitted
[Tests] add @typescript-eslint/parser v6, v7, v8
- only install peer dependencies with legacy mode when testing @typescript-eslint/parser < v6
1 parent d5e3769 commit c4fcff9

File tree

4 files changed

+68
-5
lines changed

4 files changed

+68
-5
lines changed

.github/workflows/node-18+.yml

Lines changed: 60 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,64 @@ jobs:
3838
- 10
3939
- 9
4040
- 8
41+
typescript-eslint:
42+
- 5
43+
- 6
44+
- 7
45+
- 8
46+
exclude:
47+
- eslint: 3
48+
babel-eslint: 10
49+
- eslint: 3
50+
typescript-eslint: 5
51+
- eslint: 4
52+
typescript-eslint: 5
53+
- eslint: 4.14
54+
typescript-eslint: 5
55+
- eslint: 5
56+
typescript-eslint: 5
57+
- eslint: 3
58+
typescript-eslint: 6
59+
- eslint: 4
60+
typescript-eslint: 6
61+
- eslint: 4.14
62+
typescript-eslint: 6
63+
- eslint: 5
64+
typescript-eslint: 6
65+
- eslint: 6
66+
typescript-eslint: 6
67+
- eslint: 9
68+
typescript-eslint: 6
69+
- eslint: 3
70+
typescript-eslint: 7
71+
- eslint: 4
72+
typescript-eslint: 7
73+
- eslint: 4.14
74+
typescript-eslint: 7
75+
- eslint: 5
76+
typescript-eslint: 7
77+
- eslint: 6
78+
typescript-eslint: 7
79+
- eslint: 7
80+
typescript-eslint: 7
81+
- eslint: 9
82+
typescript-eslint: 7
83+
- eslint: 3
84+
typescript-eslint: 8
85+
- eslint: 4
86+
typescript-eslint: 8
87+
- eslint: 4.14
88+
typescript-eslint: 8
89+
- eslint: 5
90+
typescript-eslint: 8
91+
- eslint: 6
92+
typescript-eslint: 8
93+
- eslint: 7
94+
typescript-eslint: 8
95+
- eslint: 9
96+
typescript-eslint: 5
97+
- node-version: 19
98+
typescript-eslint: 7
4199

42100
steps:
43101
- uses: actions/checkout@v4
@@ -46,9 +104,9 @@ jobs:
46104
with:
47105
node-version: ${{ matrix.node-version }}
48106
after_install: |
49-
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@5" "babel-eslint@${{ matrix.babel-eslint }}"
107+
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}"
50108
env:
51-
NPM_CONFIG_LEGACY_PEER_DEPS: true
109+
NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.typescript-eslint >= 6 && 'false' || 'true' }}"
52110
- run: npx ls-engines
53111
- run: npm run unit-test
54112
- uses: codecov/[email protected]

.github/workflows/node-minors.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ jobs:
100100
with:
101101
node-version: ${{ matrix.node-version }}
102102
after_install: |
103-
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.node-version >= 14 && '5' || (matrix.node-version >= 12 && '4' || (matrix.node-version >= 10 && '4.0' || (matrix.node-version >= 8 && '3' || '2'))) }}" "babel-eslint@${{ matrix.babel-eslint }}"
103+
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.node-version >= 18 && matrix.eslint >= 8 && '8' || (matrix.node-version >= 16 && matrix.eslint >= 7 && '6' || (matrix.node-version >= 14 && '5' || (matrix.node-version >= 12 && '4' || (matrix.node-version >= 10 && '4.0' || (matrix.node-version >= 8 && '3' || '2'))))) }}" "babel-eslint@${{ matrix.babel-eslint }}"
104104
skip-ls-check: ${{ matrix.node-version < 10 && true || false }}
105105
env:
106-
NPM_CONFIG_LEGACY_PEER_DEPS: true
106+
NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.node-version >= 16 && matrix.eslint >= 7 && 'false' || 'true' }}"
107107
- run: npx ls-engines
108108
if: ${{ matrix.node-version >= 12 }}
109109
- run: npm run unit-test

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
88
### Added
99
* [`no-string-refs`]: allow this.refs in > 18.3.0 ([#3807][] @henryqdineen)
1010

11+
### Changed
12+
* [Tests] add @typescript-eslint/parser v6 ([#3629][] @HenryBrown0)
13+
* [Tests] add @typescript-eslint/parser v7 and v8 ([#3629][] @hampustagerud)
14+
15+
[#3629]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3629
1116
[#3807]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3807
1217

1318
## [7.35.2] - 2024.09.03

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"@types/eslint": "=7.2.10",
5555
"@types/estree": "0.0.52",
5656
"@types/node": "^4.9.5",
57-
"@typescript-eslint/parser": "^2.34.0 || ^3.10.1 || ^4.0.0 || ^5.0.0",
57+
"@typescript-eslint/parser": "^2.34.0 || ^3.10.1 || ^4 || ^5 || ^6.20 || ^7.14.1 || ^8.4",
5858
"babel-eslint": "^8 || ^9 || ^10.1.0",
5959
"eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7",
6060
"eslint-config-airbnb-base": "^15.0.0",

0 commit comments

Comments
 (0)