Skip to content

Commit c8e883e

Browse files
jseminckjseminck
committed
Rewrite no-did-update-set-state tests with template literals
1 parent f0051bd commit c8e883e

File tree

1 file changed

+137
-137
lines changed

1 file changed

+137
-137
lines changed

‎tests/lib/rules/no-did-update-set-state.js

Lines changed: 137 additions & 137 deletions
Original file line numberDiff line numberDiff line change
@@ -30,197 +30,197 @@ const ruleTester = new RuleTester({parserOptions});
3030
ruleTester.run('no-did-update-set-state', rule, {
3131

3232
valid: [{
33-
code: [
34-
'var Hello = createReactClass({',
35-
' render: function() {',
36-
' return <div>Hello {this.props.name}</div>;',
37-
' }',
38-
'});'
39-
].join('\n')
33+
code: `
34+
var Hello = createReactClass({
35+
render: function() {
36+
return <div>Hello {this.props.name}</div>;
37+
}
38+
});
39+
`
4040
}, {
41-
code: [
42-
'var Hello = createReactClass({',
43-
' componentDidUpdate: function() {}',
44-
'});'
45-
].join('\n')
41+
code: `
42+
var Hello = createReactClass({
43+
componentDidUpdate: function() {}
44+
});
45+
`
4646
}, {
47-
code: [
48-
'var Hello = createReactClass({',
49-
' componentDidUpdate: function() {',
50-
' someNonMemberFunction(arg);',
51-
' this.someHandler = this.setState;',
52-
' }',
53-
'});'
54-
].join('\n')
47+
code: `
48+
var Hello = createReactClass({
49+
componentDidUpdate: function() {
50+
someNonMemberFunction(arg);
51+
this.someHandler = this.setState;
52+
}
53+
});
54+
`
5555
}, {
56-
code: [
57-
'var Hello = createReactClass({',
58-
' componentDidUpdate: function() {',
59-
' someClass.onSomeEvent(function(data) {',
60-
' this.setState({',
61-
' data: data',
62-
' });',
63-
' })',
64-
' }',
65-
'});'
66-
].join('\n')
56+
code: `
57+
var Hello = createReactClass({
58+
componentDidUpdate: function() {
59+
someClass.onSomeEvent(function(data) {
60+
this.setState({
61+
data: data
62+
});
63+
})
64+
}
65+
});
66+
`
6767
}, {
68-
code: [
69-
'var Hello = createReactClass({',
70-
' componentDidUpdate: function() {',
71-
' function handleEvent(data) {',
72-
' this.setState({',
73-
' data: data',
74-
' });',
75-
' }',
76-
' someClass.onSomeEvent(handleEvent)',
77-
' }',
78-
'});'
79-
].join('\n'),
68+
code: `
69+
var Hello = createReactClass({
70+
componentDidUpdate: function() {
71+
function handleEvent(data) {
72+
this.setState({
73+
data: data
74+
});
75+
}
76+
someClass.onSomeEvent(handleEvent)
77+
}
78+
});
79+
`,
8080
parser: 'babel-eslint'
8181
}],
8282

8383
invalid: [{
84-
code: [
85-
'var Hello = createReactClass({',
86-
' componentDidUpdate: function() {',
87-
' this.setState({',
88-
' data: data',
89-
' });',
90-
' }',
91-
'});'
92-
].join('\n'),
84+
code: `
85+
var Hello = createReactClass({
86+
componentDidUpdate: function() {
87+
this.setState({
88+
data: data
89+
});
90+
}
91+
});
92+
`,
9393
errors: [{
9494
message: 'Do not use setState in componentDidUpdate'
9595
}]
9696
}, {
97-
code: [
98-
'class Hello extends React.Component {',
99-
' componentDidUpdate() {',
100-
' this.setState({',
101-
' data: data',
102-
' });',
103-
' }',
104-
'}'
105-
].join('\n'),
97+
code: `
98+
class Hello extends React.Component {
99+
componentDidUpdate() {
100+
this.setState({
101+
data: data
102+
});
103+
}
104+
}
105+
`,
106106
parser: 'babel-eslint',
107107
errors: [{
108108
message: 'Do not use setState in componentDidUpdate'
109109
}]
110110
}, {
111-
code: [
112-
'var Hello = createReactClass({',
113-
' componentDidUpdate: function() {',
114-
' this.setState({',
115-
' data: data',
116-
' });',
117-
' }',
118-
'});'
119-
].join('\n'),
111+
code: `
112+
var Hello = createReactClass({
113+
componentDidUpdate: function() {
114+
this.setState({
115+
data: data
116+
});
117+
}
118+
});
119+
`,
120120
options: ['disallow-in-func'],
121121
errors: [{
122122
message: 'Do not use setState in componentDidUpdate'
123123
}]
124124
}, {
125-
code: [
126-
'class Hello extends React.Component {',
127-
' componentDidUpdate() {',
128-
' this.setState({',
129-
' data: data',
130-
' });',
131-
' }',
132-
'}'
133-
].join('\n'),
125+
code: `
126+
class Hello extends React.Component {
127+
componentDidUpdate() {
128+
this.setState({
129+
data: data
130+
});
131+
}
132+
}
133+
`,
134134
parser: 'babel-eslint',
135135
options: ['disallow-in-func'],
136136
errors: [{
137137
message: 'Do not use setState in componentDidUpdate'
138138
}]
139139
}, {
140-
code: [
141-
'var Hello = createReactClass({',
142-
' componentDidUpdate: function() {',
143-
' someClass.onSomeEvent(function(data) {',
144-
' this.setState({',
145-
' data: data',
146-
' });',
147-
' })',
148-
' }',
149-
'});'
150-
].join('\n'),
140+
code: `
141+
var Hello = createReactClass({
142+
componentDidUpdate: function() {
143+
someClass.onSomeEvent(function(data) {
144+
this.setState({
145+
data: data
146+
});
147+
})
148+
}
149+
});
150+
`,
151151
options: ['disallow-in-func'],
152152
errors: [{
153153
message: 'Do not use setState in componentDidUpdate'
154154
}]
155155
}, {
156-
code: [
157-
'class Hello extends React.Component {',
158-
' componentDidUpdate() {',
159-
' someClass.onSomeEvent(function(data) {',
160-
' this.setState({',
161-
' data: data',
162-
' });',
163-
' })',
164-
' }',
165-
'}'
166-
].join('\n'),
156+
code: `
157+
class Hello extends React.Component {
158+
componentDidUpdate() {
159+
someClass.onSomeEvent(function(data) {
160+
this.setState({
161+
data: data
162+
});
163+
})
164+
}
165+
}
166+
`,
167167
parser: 'babel-eslint',
168168
options: ['disallow-in-func'],
169169
errors: [{
170170
message: 'Do not use setState in componentDidUpdate'
171171
}]
172172
}, {
173-
code: [
174-
'var Hello = createReactClass({',
175-
' componentDidUpdate: function() {',
176-
' if (true) {',
177-
' this.setState({',
178-
' data: data',
179-
' });',
180-
' }',
181-
' }',
182-
'});'
183-
].join('\n'),
173+
code: `
174+
var Hello = createReactClass({
175+
componentDidUpdate: function() {
176+
if (true) {
177+
this.setState({
178+
data: data
179+
});
180+
}
181+
}
182+
});
183+
`,
184184
errors: [{
185185
message: 'Do not use setState in componentDidUpdate'
186186
}]
187187
}, {
188-
code: [
189-
'class Hello extends React.Component {',
190-
' componentDidUpdate() {',
191-
' if (true) {',
192-
' this.setState({',
193-
' data: data',
194-
' });',
195-
' }',
196-
' }',
197-
'}'
198-
].join('\n'),
188+
code: `
189+
class Hello extends React.Component {
190+
componentDidUpdate() {
191+
if (true) {
192+
this.setState({
193+
data: data
194+
});
195+
}
196+
}
197+
}
198+
`,
199199
parser: 'babel-eslint',
200200
errors: [{
201201
message: 'Do not use setState in componentDidUpdate'
202202
}]
203203
}, {
204-
code: [
205-
'var Hello = createReactClass({',
206-
' componentDidUpdate: function() {',
207-
' someClass.onSomeEvent((data) => this.setState({data: data}));',
208-
' }',
209-
'});'
210-
].join('\n'),
204+
code: `
205+
var Hello = createReactClass({
206+
componentDidUpdate: function() {
207+
someClass.onSomeEvent((data) => this.setState({data: data}));
208+
}
209+
});
210+
`,
211211
parser: 'babel-eslint',
212212
options: ['disallow-in-func'],
213213
errors: [{
214214
message: 'Do not use setState in componentDidUpdate'
215215
}]
216216
}, {
217-
code: [
218-
'class Hello extends React.Component {',
219-
' componentDidUpdate() {',
220-
' someClass.onSomeEvent((data) => this.setState({data: data}));',
221-
' }',
222-
'}'
223-
].join('\n'),
217+
code: `
218+
class Hello extends React.Component {
219+
componentDidUpdate() {
220+
someClass.onSomeEvent((data) => this.setState({data: data}));
221+
}
222+
}
223+
`,
224224
parser: 'babel-eslint',
225225
options: ['disallow-in-func'],
226226
errors: [{

0 commit comments

Comments
 (0)