Temp commit

Author: pfhayes

index.js

@@ -9,9 +9,10 @@ const allRules = {
   'display-name': require('./lib/rules/display-name'),
   'forbid-component-props': require('./lib/rules/forbid-component-props'),
   'forbid-elements': require('./lib/rules/forbid-elements'),
-  'forbid-prop-types': require('./lib/rules/forbid-prop-types'),
   'forbid-foreign-prop-types': require('./lib/rules/forbid-foreign-prop-types'),
+  'forbid-prop-types': require('./lib/rules/forbid-prop-types'),
   'jsx-boolean-value': require('./lib/rules/jsx-boolean-value'),
+  'jsx-child-element-spacing': require('./lib/rules/jsx-child-element-spacing'),
   'jsx-closing-bracket-location': require('./lib/rules/jsx-closing-bracket-location'),
   'jsx-closing-tag-location': require('./lib/rules/jsx-closing-tag-location'),
   'jsx-curly-spacing': require('./lib/rules/jsx-curly-spacing'),
@@ -23,12 +24,12 @@ const allRules = {
   'jsx-indent-props': require('./lib/rules/jsx-indent-props'),
   'jsx-key': require('./lib/rules/jsx-key'),
   'jsx-max-props-per-line': require('./lib/rules/jsx-max-props-per-line'),
-  'jsx-one-expression-per-line': require('./lib/rules/jsx-one-expression-per-line'),
   'jsx-no-bind': require('./lib/rules/jsx-no-bind'),
   'jsx-no-comment-textnodes': require('./lib/rules/jsx-no-comment-textnodes'),
   'jsx-no-duplicate-props': require('./lib/rules/jsx-no-duplicate-props'),
   'jsx-no-literals': require('./lib/rules/jsx-no-literals'),
   'jsx-no-target-blank': require('./lib/rules/jsx-no-target-blank'),
+  'jsx-one-expression-per-line': require('./lib/rules/jsx-one-expression-per-line'),
   'jsx-no-undef': require('./lib/rules/jsx-no-undef'),
   'jsx-curly-brace-presence': require('./lib/rules/jsx-curly-brace-presence'),
   'jsx-pascal-case': require('./lib/rules/jsx-pascal-case'),

lib/rules/jsx-child-element-spacing.js

@@ -1,8 +1,47 @@
 'use strict';
 
+const INLINE_ELEMENTS = [
+  "a",
+  "abbr",
+  "acronym",
+  "b",
+  "bdo",
+  "big",
+  "br",
+  "button",
+  "cite",
+  "code",
+  "dfn",
+  "em",
+  "i",
+  "img",
+  "input",
+  "kbd",
+  "label",
+  "map",
+  "object",
+  "q",
+  "samp",
+  "script",
+  "select",
+  "small",
+  "span",
+  "strong",
+  "sub",
+  "sup",
+  "textarea",
+  "tt",
+  "var"
+];
+
 module.exports = {
   meta: {
-    docs: {},
+    docs: {
+      description: 'Ensures inline tags are not rendered without spaces between them',
+      category: 'Stylistic Issues',
+      recommended: false,
+    },
+    fixable: false,
     schema: [
       {
         type: 'object',
@@ -12,7 +51,61 @@ module.exports = {
       }
     ]
   },
-  create: function (/* context */) {
-    return {};
+  create: function (context) {
+    const sourceCode = context.getSourceCode();
+
+    const isInlineElement = (node) => (
+      node.type === 'JSXElement' &&
+      node.openingElement &&
+      node.openingElement.name &&
+      node.openingElement.name.type === 'JSXIdentifier' &&
+      INLINE_ELEMENTS.includes(node.openingElement.name.name)
+    );
+
+    return {
+      JSXElement: function(node) {
+        let lastChild = null;
+        let child = null;
+        let nextChild = null;
+        (node.children.concat([null])).forEach((nextChild) => {
+          if (
+            (lastChild || nextChild) &&
+            (!lastChild || isInlineElement(lastChild)) &&
+            (child && child.type === 'Literal') &&
+            (!nextChild || isInlineElement(nextChild)) &&
+            true
+          ) {
+            if (lastChild && child.value.match(/^\s*\n\s*\S/)) {
+              context.report({
+                node: child,
+                loc: child.loc,
+                message: 'CASE A: ' + child.value,
+              });
+            } else if (lastChild && nextChild && child.value.match(/\n +$/)) {
+              context.report({
+                node: child,
+                loc: child.loc,
+                message: 'CASE B: ' + child.value,
+              });
+            } else if (nextChild && child.value.match(/\S\s*\n\s*$/)) {
+              context.report({
+                node: child,
+                loc: child.loc,
+                message: 'CASE C: ' + child.value,
+              });
+            } else if (lastChild && nextChild && child.value.match(/^ +\n/)) {
+              context.report({
+                node: child,
+                loc: child.loc,
+                message: 'CASE D: ' + child.value,
+              });
+            }
+          }
+          lastChild = child;
+          child = nextChild;
+        });
+        Array.map
+      },
+    };
   }
 };

tests/lib/rules/jsx-child-element-spacing.js

@@ -9,7 +9,8 @@ const parserOptions = {
   }
 };
 
-const ERROR_MESSAGE = [{message: 'Ambiguous spacing between child elements.'}];
+// const ERROR_MESSAGE = [{message: 'Ambiguous spacing between child elements.'}];
+const ERROR_MESSAGE = [{}];
 
 const ruleTester = new RuleTester({parserOptions});
 ruleTester.run('jsx-child-element-spacing', rule, {
@@ -40,13 +41,6 @@ ruleTester.run('jsx-child-element-spacing', rule, {
         bar
       </App>
     `
-  }, {
-    code: `
-      <App>
-        <a>foo</a>
-        <a>bar</a>
-      </App>
-    `
   }, {
     code: `
       <App>
@@ -131,6 +125,14 @@ ruleTester.run('jsx-child-element-spacing', rule, {
       </App>
     `,
     errors: ERROR_MESSAGE
+  }, {
+    code: `
+      <App>
+        <a>foo</a>
+        <a>bar</a>
+      </App>
+    `,
+    errors: ERROR_MESSAGE
   }, {
     code: `
       <App>
@@ -163,7 +165,10 @@ ruleTester.run('jsx-child-element-spacing', rule, {
         <a href="https://js.org">another</a>
       </App>
     `,
-    errors: ERROR_MESSAGE
+    errors: [
+      ERROR_MESSAGE,
+      ERROR_MESSAGE,
+    ],
   }, {
     code: `
       <App>