Skip to content

Commit d009e45

Browse files
committed
Fix quotes rule in .eslintrc
1 parent b9f894e commit d009e45

File tree

5 files changed

+26
-26
lines changed

5 files changed

+26
-26
lines changed

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
"one-var": 0,
130130
"operator-assignment": [2, "always"],
131131
"padded-blocks": 0,
132-
"quotes": [2, "singe"],
132+
"quotes": [2, "single"],
133133
"quote-props": 0,
134134
"semi": [2, "always"],
135135
"sort-vars": 0,

lib/rules/jsx-uses-react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = function(context) {
1616
i,
1717
len;
1818

19-
while (scope.type !== "global") {
19+
while (scope.type !== 'global') {
2020
scope = scope.upper;
2121
variables = [].concat.apply(scope.variables, variables);
2222
}

lib/rules/react-in-jsx-scope.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
* @fileoverview Validate that React is in scope when using JSX.
33
* @author Glen Mailer
44
*/
5-
"use strict";
5+
'use strict';
66

77
// -----------------------------------------------------------------------------
88
// Rule Definition
99
// -----------------------------------------------------------------------------
1010

1111
module.exports = function(context) {
1212

13-
var NOT_DEFINED_MESSAGE = "'React' must be in scope when using JSX";
13+
var NOT_DEFINED_MESSAGE = '\'React\' must be in scope when using JSX';
1414

1515
function findVariable(variables, name) {
1616
var i, len;
@@ -26,7 +26,7 @@ module.exports = function(context) {
2626
var scope = context.getScope(),
2727
variables = scope.variables;
2828

29-
while (scope.type !== "global") {
29+
while (scope.type !== 'global') {
3030
scope = scope.upper;
3131
variables = scope.variables.concat(variables);
3232
}
@@ -36,7 +36,7 @@ module.exports = function(context) {
3636

3737
return {
3838

39-
"JSXOpeningElement": function(node) {
39+
'JSXOpeningElement': function(node) {
4040
var variables = variablesInScope();
4141
if (!findVariable(variables, 'React')) {
4242
context.report(node, NOT_DEFINED_MESSAGE);

tests/lib/rules/jsx-uses-react.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* @author Glen Mailer
44
*/
55

6-
"use strict";
6+
'use strict';
77

88
// -----------------------------------------------------------------------------
99
// Requirements
@@ -18,14 +18,14 @@ var ESLintTester = require('eslint-tester');
1818

1919
var eslintTester = new ESLintTester(eslint);
2020
eslint.defineRule('jsx-uses-react', require('../../../lib/rules/jsx-uses-react'));
21-
eslintTester.addRuleTest("node_modules/eslint/lib/rules/no-unused-vars", {
21+
eslintTester.addRuleTest('node_modules/eslint/lib/rules/no-unused-vars', {
2222
valid: [
23-
{code: "/*eslint jsx-uses-react:1*/ var App, React; <App />;", ecmaFeatures: {jsx: true}},
24-
{code: "/*eslint jsx-uses-react:1*/ var React; <div />;", ecmaFeatures: {jsx: true}},
25-
{code: "/*eslint jsx-uses-react:1*/ var React; (function () { <div /> })();", ecmaFeatures: {jsx: true}}
23+
{code: '/*eslint jsx-uses-react:1*/ var App, React; <App />;', ecmaFeatures: {jsx: true}},
24+
{code: '/*eslint jsx-uses-react:1*/ var React; <div />;', ecmaFeatures: {jsx: true}},
25+
{code: '/*eslint jsx-uses-react:1*/ var React; (function () { <div /> })();', ecmaFeatures: {jsx: true}}
2626
],
2727
invalid: [
28-
{code: "/*eslint jsx-uses-react:1*/ var React;",
29-
errors: [{message: "React is defined but never used"}], ecmaFeatures: {jsx: true}}
28+
{code: '/*eslint jsx-uses-react:1*/ var React;',
29+
errors: [{message: 'React is defined but never used'}], ecmaFeatures: {jsx: true}}
3030
]
3131
});

tests/lib/rules/react-in-jsx-scope.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* @author Glen Mailer
44
*/
55

6-
"use strict";
6+
'use strict';
77

88
// -----------------------------------------------------------------------------
99
// Requirements
@@ -17,21 +17,21 @@ var ESLintTester = require('eslint-tester');
1717
// -----------------------------------------------------------------------------
1818

1919
var eslintTester = new ESLintTester(eslint);
20-
eslintTester.addRuleTest("lib/rules/react-in-jsx-scope", {
20+
eslintTester.addRuleTest('lib/rules/react-in-jsx-scope', {
2121
valid: [
22-
{code: "var React, App; <App />;", args: [1, {vars: "all"}], ecmaFeatures: {jsx: true}},
23-
{code: "var React; <img />;", args: [1, {vars: "all"}], ecmaFeatures: {jsx: true}},
24-
{code: "var React; <x-gif />;", args: [1, {vars: "all"}], ecmaFeatures: {jsx: true}},
25-
{code: "var React, App, a=1; <App attr={a} />;", ecmaFeatures: {jsx: true}},
26-
{code: "var React, App, a=1; function elem() { return <App attr={a} />; }",
22+
{code: 'var React, App; <App />;', args: [1, {vars: 'all'}], ecmaFeatures: {jsx: true}},
23+
{code: 'var React; <img />;', args: [1, {vars: 'all'}], ecmaFeatures: {jsx: true}},
24+
{code: 'var React; <x-gif />;', args: [1, {vars: 'all'}], ecmaFeatures: {jsx: true}},
25+
{code: 'var React, App, a=1; <App attr={a} />;', ecmaFeatures: {jsx: true}},
26+
{code: 'var React, App, a=1; function elem() { return <App attr={a} />; }',
2727
ecmaFeatures: {jsx: true}}
2828
],
2929
invalid: [
30-
{code: "var App, a = <App />;",
31-
errors: [{message: "'React' must be in scope when using JSX"}], ecmaFeatures: {jsx: true}},
32-
{code: "var a = <App />;",
33-
errors: [{message: "'React' must be in scope when using JSX"}], ecmaFeatures: {jsx: true}},
34-
{code: "var a = <img />;",
35-
errors: [{message: "'React' must be in scope when using JSX"}], ecmaFeatures: {jsx: true}}
30+
{code: 'var App, a = <App />;',
31+
errors: [{message: '\'React\' must be in scope when using JSX'}], ecmaFeatures: {jsx: true}},
32+
{code: 'var a = <App />;',
33+
errors: [{message: '\'React\' must be in scope when using JSX'}], ecmaFeatures: {jsx: true}},
34+
{code: 'var a = <img />;',
35+
errors: [{message: '\'React\' must be in scope when using JSX'}], ecmaFeatures: {jsx: true}}
3636
]
3737
});

0 commit comments

Comments
 (0)