Skip to content

Commit ddba876

Browse files
brettdhljharb
authored andcommitted
Fix isRequired tests after custom proptypes changes
The typos were being ignored, because without `PropTypes`, the un-namespaced identifiers looked like custom proptypes.
1 parent 4abebc3 commit ddba876

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

tests/lib/rules/no-typos.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -899,33 +899,37 @@ ruleTester.run('no-typos', rule, {
899899
message: 'Typo in declared prop type: objectof'
900900
}]
901901
}, {
902-
code: `class Component extends React.Component {};
902+
code: `
903+
const PropTypes = require('prop-types');
904+
class Component extends React.Component {};
903905
Component.propTypes = {
904-
a: string.isrequired,
905-
b: shape({
906-
c: number
906+
a: PropTypes.string.isrequired,
907+
b: PropTypes.shape({
908+
c: PropTypes.number
907909
}).isrequired
908910
}
909911
`,
910912
parserOptions: parserOptions,
911913
errors: [{
912-
message: 'Typo in declared prop type: isrequired'
914+
message: 'Typo in prop type chain qualifier: isrequired'
913915
}, {
914916
message: 'Typo in prop type chain qualifier: isrequired'
915917
}]
916918
}, {
917-
code: `class Component extends React.Component {};
919+
code: `
920+
const PropTypes = require('prop-types');
921+
class Component extends React.Component {};
918922
Component.propTypes = {
919-
a: string.isrequired,
920-
b: shape({
921-
c: number
923+
a: PropTypes.string.isrequired,
924+
b: PropTypes.shape({
925+
c: PropTypes.number
922926
}).isrequired
923927
}
924928
`,
925929
parser: 'babel-eslint',
926930
parserOptions: parserOptions,
927931
errors: [{
928-
message: 'Typo in declared prop type: isrequired'
932+
message: 'Typo in prop type chain qualifier: isrequired'
929933
}, {
930934
message: 'Typo in prop type chain qualifier: isrequired'
931935
}]

0 commit comments

Comments
 (0)