Merge pull request #123 from Cellule/sort_prop_types_key

Fix `jsx-sort-prop-types` support for keys as string

Author: yannickcr

lib/rules/jsx-sort-prop-types.js

@@ -35,15 +35,19 @@ module.exports = function(context) {
     );
   }
 
+  function getKey(node) {
+    return node.key.type === 'Identifier' ? node.key.name : node.key.value;
+  }
+
   /**
    * Checks if propTypes declarations are sorted
    * @param {Array} declarations The array of AST nodes being checked.
    * @returns {void}
    */
   function checkSorted(declarations) {
     declarations.reduce(function(prev, curr) {
-      var prevPropName = prev.key.name;
-      var currenPropName = curr.key.name;
+      var prevPropName = getKey(prev);
+      var currenPropName = getKey(curr);
 
       if (ignoreCase) {
         prevPropName = prevPropName.toLowerCase();

tests/lib/rules/jsx-sort-prop-types.js

@@ -161,6 +161,21 @@ eslintTester.addRuleTest('lib/rules/jsx-sort-prop-types', {
         classes: true,
         jsx: true
       }
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  render() {',
+        '    return <div>Hello</div>;',
+        '  }',
+        '}',
+        'Hello.propTypes = {',
+        '  "aria-controls": React.PropTypes.string',
+        '};'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      args: [1, {
+        ignoreCase: true
+      }]
     }
   ],