Skip to content

Commit e05f47a

Browse files
author
Roy Sutton
committed
Address review feedback
1 parent cbd90a3 commit e05f47a

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

lib/rules/no-invalid-default-props.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ module.exports = {
7373
* @returns {Boolean} `true` if the node is a defaultProps declaration, `false` if not
7474
*/
7575
function isDefaultPropsDeclaration(node) {
76-
return (getPropertyName(node) === 'defaultProps' || getPropertyName(node) === 'getDefaultProps');
76+
var propName = getPropertyName(node);
77+
return (propName === 'defaultProps' || propName === 'getDefaultProps');
7778
}
7879

7980
/**
@@ -424,7 +425,8 @@ module.exports = {
424425

425426
// e.g.:
426427
// MyComponent.propTypes.baz = React.PropTypes.string;
427-
if (node.parent.type === 'MemberExpression' && node.parent.parent.type === 'AssignmentExpression') {
428+
if (node.parent.type === 'MemberExpression' && node.parent.parent &&
429+
node.parent.parent.type === 'AssignmentExpression') {
428430

429431
if (isPropType) {
430432
addPropTypesToComponent(component, [{
@@ -520,8 +522,9 @@ module.exports = {
520522
return;
521523
}
522524

523-
var isPropType = getPropertyName(node) === 'propTypes';
524-
var isDefaultProp = getPropertyName(node) === 'defaultProps' || getPropertyName(node) === 'getDefaultProps';
525+
var propName = getPropertyName(node);
526+
var isPropType = propName === 'propTypes';
527+
var isDefaultProp = propName === 'defaultProps' || propName === 'getDefaultProps';
525528

526529
if (!isPropType && !isDefaultProp) {
527530
return;

0 commit comments

Comments
 (0)