review changes

Ethan Goldberg · Ethan Goldberg · commit ec94608fa63c · 2017-05-26T12:06:44.000-07:00
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -305,7 +305,7 @@ module.exports = {
      * @param {string} the identifier to strip
      */
     function stripQuotes(string) {
-      if (string[0] === '\'' || string[0] === '"') {
+      if (string[0] === '\'' || string[0] === '"' && string[0] === string[string.length - 1]) {
         return string.slice(1, string.length - 1);
       }
       return string;

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ module.exports = {`
`305`	`305`	`* @param {string} the identifier to strip`
`306`	`306`	`*/`
`307`	`307`	`function stripQuotes(string) {`
`308`		`- if (string[0] === '\'' \|\| string[0] === '"') {`
	`308`	`+ if (string[0] === '\'' \|\| string[0] === '"' && string[0] === string[string.length - 1]) {`
`309`	`309`	`return string.slice(1, string.length - 1);`
`310`	`310`	`}`
`311`	`311`	`return string;`