Remove @ts-expect-error and add comments

Author: y-hsgw

lib/rules/jsx-closing-bracket-location.js

@@ -196,8 +196,10 @@ module.exports = {
      */
     function getTokensLocations(node) {
       const sourceCode = context.getSourceCode();
+      // The types differ between ASTNode and ESTree.Node.
       // @ts-expect-error
       const opening = sourceCode.getFirstToken(node).loc.start;
+      // The types differ between ASTNode and ESTree.Node.
       // @ts-expect-error
       const closing = sourceCode.getLastTokens(node, node.selfClosing ? 2 : 1)[0].loc.start;
       const tag = sourceCode.getFirstToken(node.name).loc.start;

lib/rules/jsx-equals-spacing.js

@@ -62,9 +62,10 @@ module.exports = {
 
           const sourceCode = context.getSourceCode();
           const equalToken = sourceCode.getTokenAfter(attrNode.name);
-          // @ts-expect-error
+          if (equalToken.type !== 'Punctuator') {
+            return;
+          }
           const spacedBefore = sourceCode.isSpaceBetweenTokens(attrNode.name, equalToken);
-          // @ts-expect-error
           const spacedAfter = sourceCode.isSpaceBetweenTokens(equalToken, attrNode.value);
 
           if (config === 'never') {

lib/rules/jsx-indent-props.js

@@ -141,6 +141,7 @@ module.exports = {
      * @return {Number} Indent
      */
     function getNodeIndent(node) {
+      // The types differ between ASTNode and ESTree.Node.
       // @ts-expect-error
       let src = context.getSourceCode().getText(node, node.loc.start.column + extraColumnStart);
       const lines = src.split('\n');

lib/rules/no-access-state-in-setstate.js

@@ -107,8 +107,8 @@ module.exports = {
           && node.object.type === 'ThisExpression'
           && isClassComponent()
         ) {
+          /** @type {import("eslint").Rule.Node} */
           let current = node;
-          // @ts-expect-error
           while (current.type !== 'Program') {
             // Reporting if this.state is directly within this.setState
             if (isFirstArgumentInSetStateCall(current, node)) {
@@ -119,56 +119,51 @@ module.exports = {
             }
 
             // Storing all functions and methods that contains this.state
-            // @ts-expect-error
-            if (current.type === 'MethodDefinition') {
+            if (current.type === 'MethodDefinition' && current.key.type === 'Identifier') {
               methods.push({
-                // @ts-expect-error
                 methodName: current.key.name,
                 node,
               });
               break;
-            // @ts-expect-error
-            } else if (current.type === 'FunctionExpression' && current.parent.key) {
+            } else if (
+              current.type === 'FunctionExpression'
+              && (current.parent.type === 'Property' || current.parent.type === 'MethodDefinition')
+              && current.parent.key.type === 'Identifier'
+              && current.parent.key
+            ) {
               methods.push({
-                // @ts-expect-error
                 methodName: current.parent.key.name,
                 node,
               });
               break;
             }
 
             // Storing all variables containing this.state
-            // @ts-expect-error
-            if (current.type === 'VariableDeclarator') {
+            if (current.type === 'VariableDeclarator' && current.id.type === 'Identifier') {
               vars.push({
                 node,
                 scope: context.getScope(),
-                // @ts-expect-error
                 variableName: current.id.name,
               });
               break;
             }
 
-            // @ts-expect-error
             current = current.parent;
           }
         }
       },
 
       Identifier(node) {
         // Checks if the identifier is a variable within an object
+        /** @type {import("eslint").Rule.Node} */
         let current = node;
         while (current.parent.type === 'BinaryExpression') {
-          // @ts-expect-error
           current = current.parent;
         }
         if (
-          // @ts-expect-error
-          current.parent.value === current
-          // @ts-expect-error
-          || current.parent.object === current
+          (current.parent.type === 'Property' && current.parent.value === current)
+          || (current.parent.type === 'MemberExpression' && current.parent.object === current)
         ) {
-          // @ts-expect-error
           while (current.type !== 'Program') {
             if (isFirstArgumentInSetStateCall(current, node)) {
               vars
@@ -179,7 +174,6 @@ module.exports = {
                   });
                 });
             }
-            // @ts-expect-error
             current = current.parent;
           }
         }

lib/rules/no-danger-with-children.js

@@ -129,8 +129,8 @@ module.exports = {
           let props = node.arguments[1];
 
           if (props.type === 'Identifier') {
-            // @ts-expect-error
-            const variable = variableUtil.variablesInScope(context).find((item) => item.name === props.name);
+            const name = props.name;
+            const variable = variableUtil.variablesInScope(context).find((item) => item.name === name);
             if (variable && variable.defs.length && variable.defs[0].node.init) {
               props = variable.defs[0].node.init;
             }

lib/rules/no-deprecated.js

@@ -236,14 +236,13 @@ module.exports = {
 
       VariableDeclarator(node) {
         const reactModuleName = getReactModuleName(node);
-        // @ts-expect-error
-        const isRequire = node.init && node.init.callee && node.init.callee.name === 'require';
-        const isReactRequire = node.init
-        // @ts-expect-error
+        const isRequire = node.init.type === 'CallExpression'
+          && node.init.callee && node.init.callee.type === 'Identifier'
+          && node.init.callee.name === 'require';
+        const isReactRequire = node.init.type === 'CallExpression'
           && node.init.arguments
-          // @ts-expect-error
           && node.init.arguments.length
-          // @ts-expect-error
+          && node.init.arguments[0].type === 'Literal'
           && typeof MODULES[node.init.arguments[0].value] !== 'undefined';
         const isDestructuring = node.id && node.id.type === 'ObjectPattern';