Bump coverage to 100%

Author: Pearce-Ropion

lib/rules/jsx-no-literals.js

@@ -214,28 +214,22 @@ module.exports = {
      * @returns {boolean}
      */
     function isRequireStatement(node) {
-      if (!node) return false;
-      switch (node.type) {
-        case 'CallExpression':
-          if (node.callee.type === 'Identifier') {
-            return node.callee.name === 'require';
-          }
-          break;
-
-        case 'MemberExpression':
-          if (node.object.type === 'Super') return false;
-          return isRequireStatement(node.object);
-
-        default:
-          break;
+      if (node.type === 'CallExpression') {
+        if (node.callee.type === 'Identifier') {
+          return node.callee.name === 'require';
+        }
+      } else if (node.type === 'MemberExpression') {
+        return isRequireStatement(node.object);
       }
+
+      return false;
     }
 
     /**
      * Gets the name of the given JSX element. Supports nested
      * JSXMemeberExpressions. ie `<Namesapce.Component.SubComponent />`
      * @param {ASTNode} node
-     * @returns {(string | undefined)[]}
+     * @returns {(string | undefined)[] | undefined}
      */
     function getJSXElementName(node) {
       if (node.openingElement.name.type === 'JSXIdentifier') {
@@ -255,7 +249,6 @@ module.exports = {
           }
 
           current = current.object;
-          if (!current) break;
         }
 
         if (current.type === 'JSXIdentifier') {
@@ -275,8 +268,6 @@ module.exports = {
           }
         }
       }
-
-      return [undefined, undefined];
     }
 
     /**
@@ -377,15 +368,18 @@ module.exports = {
       for (const ancestor of allAncestorElements) {
         const isClosestJSXAncestor = ancestor === allAncestorElements[0];
 
-        const [ancestorName, compoundAncestorName] = getJSXElementName(ancestor);
-        if (ancestorName) {
-          const ancestorConfig = compoundAncestorName
-            ? config.elementOverrides[compoundAncestorName] || config.elementOverrides[ancestorName]
-            : config.elementOverrides[ancestorName];
-
-          if (ancestorConfig) {
-            if (isClosestJSXAncestor || ancestorConfig.applyToNestedElements) {
-              return ancestorConfig;
+        const elementNames = getJSXElementName(ancestor);
+        if (elementNames && Array.isArray(elementNames) && elementNames.length === 2) {
+          const [ancestorName, compoundAncestorName] = elementNames;
+          if (ancestorName) {
+            const ancestorConfig = compoundAncestorName
+              ? config.elementOverrides[compoundAncestorName] || config.elementOverrides[ancestorName]
+              : config.elementOverrides[ancestorName];
+
+            if (ancestorConfig) {
+              if (isClosestJSXAncestor || ancestorConfig.applyToNestedElements) {
+                return ancestorConfig;
+              }
             }
           }
         }

tests/lib/rules/jsx-no-literals.js

@@ -404,6 +404,12 @@ ruleTester.run('jsx-no-literals', rule, {
       `,
       options: [{ elementOverrides: { T: { allowedStrings: ['foo'] }, U: { allowedStrings: ['foo'] } } }],
     },
+    {
+      code: `
+        import { T } from 'foo';
+        <T>{'foo'}</T>
+      `,
+    },
     {
       code: `
         import { T as U } from 'foo';
@@ -432,6 +438,13 @@ ruleTester.run('jsx-no-literals', rule, {
       `,
       options: [{ elementOverrides: { T: { allowElement: true } } }],
     },
+    {
+      code: `
+        const foo = 2;
+        <T>foo</T>
+      `,
+      options: [{ elementOverrides: { T: { allowElement: true } } }],
+    },
     {
       code: `
         <T.U>foo</T.U>