Skip to content

Commit ffd8ea7

Browse files
aduthyannickcr
authored andcommitted
Fix jsx-no-target-blank to target only anchor elements
1 parent 79b56b4 commit ffd8ea7

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/rules/jsx-no-target-blank.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ module.exports = {
2121
create: function(context) {
2222
return {
2323
JSXAttribute: function(node) {
24+
if (node.parent.name.name !== 'a') {
25+
return;
26+
}
27+
2428
if (node.name.name === 'target' && node.value.value === '_blank') {
2529
var relFound = false;
2630
var attrs = node.parent.attributes;

tests/lib/rules/jsx-no-target-blank.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ ruleTester.run('jsx-no-target-blank', rule, {
2929
{code: '<a randomTag></a>', parserOptions: parserOptions},
3030
{code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>', parserOptions: parserOptions},
3131
{code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>', parserOptions: parserOptions},
32-
{code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions}
32+
{code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions},
33+
{code: '<p target="_blank"></p>', parserOptions: parserOptions}
3334
],
3435
invalid: [
3536
{code: '<a target="_blank"></a>', parserOptions: parserOptions,

0 commit comments

Comments
 (0)