Fix infinite loop and nonType bug.#7
Open
Feng-Zihao wants to merge 4 commits intojtriley:masterfrom
Feng-Zihao:master
Open
Fix infinite loop and nonType bug.#7Feng-Zihao wants to merge 4 commits intojtriley:masterfrom Feng-Zihao:master
Feng-Zihao wants to merge 4 commits intojtriley:masterfrom
Feng-Zihao:master
Conversation
Owner
|
@Feng-Zihao Sorry but could you redo this PR against the latest develop branch? The master branch is for releases only. All PRs in the future should go to the develop branch. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1, it's a logic bug in stun_test
2, there're stun implementation which do not have 'changed address' attribute in response.
In this case, there's not enough evidence to judge NAT type.