TextEditor: Restore JUCE 7 behaviour for the first line's alignment when line spacing > 1

Author: szarvas

modules/juce_gui_basics/widgets/juce_TextEditor.cpp

@@ -817,8 +817,24 @@ float TextEditor::getYOffset() const
 {
     const auto bottomY = getMaximumTextHeight();
 
+    const auto juce7LineSpacingOffset = std::invoke ([&]
+    {
+         if (approximatelyEqual (lineSpacing, 1.0f) || textStorage->isEmpty())
+             return 0.0f;
+
+         const auto& lineMetrics = textStorage->front().value->getShapedText().getLineMetricsForGlyphRange();
+
+         if (lineMetrics.isEmpty())
+             return 0.0f;
+
+         const auto& line = lineMetrics.front().value;
+
+         jassert (lineSpacing >= 1.0f);
+         return line.maxAscent * (1.0f / lineSpacing - 1.0f);
+    });
+
     if (justification.testFlags (Justification::top) || isTextStorageHeightGreaterEqualThan ((float) bottomY))
-        return 0;
+        return juce7LineSpacingOffset;
 
     auto bottom = jmax (0.0f, (float) bottomY - getTextStorageHeight());
 

modules/juce_gui_basics/widgets/juce_TextEditorModel.cpp

@@ -202,6 +202,12 @@ class TextEditor::ParagraphsModel
 
     bool isEmpty() const { return storage.empty(); }
 
+    ParagraphItem front() const
+    {
+        jassert (! ranges.isEmpty());
+        return { ranges.get (0), storage.front() };
+    }
+
     ParagraphItem back() const
     {
         jassert (! ranges.isEmpty());
@@ -417,6 +423,7 @@ class TextEditor::TextEditorStorage
     auto end() const { return paragraphs.end(); }
 
     auto isEmpty() const { return paragraphs.isEmpty(); }
+    auto front() const { return paragraphs.front(); }
     auto back() const { return paragraphs.back(); }
 
     std::optional<Font> getLastFont() const