Skip to content

Commit e465b71

Browse files
committed
Docs: Update language to be more diplomatic
1 parent 83e5264 commit e465b71

File tree

9 files changed

+34
-17
lines changed

9 files changed

+34
-17
lines changed

modules/juce_audio_devices/native/juce_ALSA_linux.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1239,7 +1239,7 @@ class ALSAAudioIODeviceType final : public AudioIODeviceType
12391239
bool isOutput = (ioid != "Input");
12401240
bool isInput = (ioid != "Output");
12411241

1242-
// alsa is stupid here, it advertises dmix and dsnoop as input/output devices, but
1242+
// ALSA advertises dmix and dsnoop as input/output devices, but
12431243
// opening dmix as input, or dsnoop as output will trigger errors
12441244
isInput = isInput && ! id.startsWith ("dmix");
12451245
isOutput = isOutput && ! id.startsWith ("dsnoop");

modules/juce_audio_plugin_client/juce_audio_plugin_client_VST2.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,8 @@ class JuceVSTWrapper final : public AudioProcessorListener,
398398
// if this fails, the host hasn't called resume() before processing
399399
jassert (isProcessing);
400400

401-
// (tragically, some hosts actually need this, although it's stupid to have
402-
// to do it here.)
401+
// (tragically, some hosts actually need this, although it's unfortunate to have
402+
// to do it here)
403403
if (! isProcessing)
404404
resume();
405405

modules/juce_audio_processors_headless/format_types/juce_VST3Headers.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
// <cstring> or <string.h>, which prevents the use of stricmp in JUCE source.
4444
#include <cstring>
4545

46-
// Wow, those Steinberg guys really don't worry too much about compiler warnings.
4746
JUCE_BEGIN_IGNORE_WARNINGS_LEVEL_MSVC (0, 4505 4702 6011 6031 6221 6386 6387 6330 6001 28199)
4847

4948
JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-W#warnings",

modules/juce_audio_processors_headless/processors/juce_AudioProcessor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1000,7 +1000,7 @@ class JUCE_API AudioProcessor : private AAXClientExtensions
10001000
the correct size before returning it. If you implement this method, you must
10011001
also implement the hasEditor() method and make it return true.
10021002
1003-
Remember not to do anything silly like allowing your processor to keep a pointer to
1003+
Remember not to do anything like allowing your processor to keep a pointer to
10041004
the component that gets created - it could be deleted later without any warning, which
10051005
would make your pointer into a dangler. Use the getActiveEditor() method instead.
10061006

modules/juce_core/memory/juce_HeavyweightLeakedObjectDetector.h

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,15 @@ class HeavyweightLeakedObjectDetector
8181
the 'OwnerClass' template parameter - the name and stack trace of its creation should
8282
have been printed by the lines above.
8383
84-
If you're leaking, it's probably because you're using old-fashioned, non-RAII techniques for
85-
your object management. Tut, tut. Always, always use std::unique_ptrs, OwnedArrays,
86-
ReferenceCountedObjects, etc, and avoid the 'delete' operator at all costs!
84+
Many errors like this are caused by using old-fashioned, non-RAII techniques for
85+
object management. If you're seeing this, it's a good idea to double-check
86+
that you're using std::unique_ptrs, OwnedArrays,
87+
ReferenceCountedObjects, etc, and avoiding manual calls to the 'delete'
88+
operator at all costs!
89+
90+
You may also see this error if JUCE's shutdown code is called while an object
91+
containing a leak detector is still alive (perhaps declared as a namespace-scope
92+
static).
8793
*/
8894
jassertfalse;
8995
}

modules/juce_core/memory/juce_LeakedObjectDetector.h

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,15 @@ class LeakedObjectDetector
7373
not be this particular deletion that's at fault - the incorrect one may have happened
7474
at an earlier point in the program, and simply not been detected until now.
7575
76-
Most errors like this are caused by using old-fashioned, non-RAII techniques for
77-
your object management. Tut, tut. Always, always use std::unique_ptrs, OwnedArrays,
78-
ReferenceCountedObjects, etc, and avoid the 'delete' operator at all costs!
76+
Many errors like this are caused by using old-fashioned, non-RAII techniques for
77+
object management. If you're seeing this, it's a good idea to double-check
78+
that you're using std::unique_ptrs, OwnedArrays,
79+
ReferenceCountedObjects, etc, and avoiding manual calls to the 'delete'
80+
operator at all costs!
81+
82+
You may also see this error if JUCE's shutdown code is called while an object
83+
containing a leak detector is still alive (perhaps declared as a namespace-scope
84+
static).
7985
*/
8086
jassertfalse;
8187
}
@@ -97,9 +103,15 @@ class LeakedObjectDetector
97103
/** If you hit this, then you've leaked one or more objects of the type specified by
98104
the 'OwnerClass' template parameter - the name should have been printed by the line above.
99105
100-
If you're leaking, it's probably because you're using old-fashioned, non-RAII techniques for
101-
your object management. Tut, tut. Always, always use std::unique_ptrs, OwnedArrays,
102-
ReferenceCountedObjects, etc, and avoid the 'delete' operator at all costs!
106+
Many errors like this are caused by using old-fashioned, non-RAII techniques for
107+
object management. If you're seeing this, it's a good idea to double-check
108+
that you're using std::unique_ptrs, OwnedArrays,
109+
ReferenceCountedObjects, etc, and avoiding manual calls to the 'delete'
110+
operator at all costs!
111+
112+
You may also see this error if JUCE's shutdown code is called while an object
113+
containing a leak detector is still alive (perhaps declared as a namespace-scope
114+
static).
103115
*/
104116
jassertfalse;
105117
}

modules/juce_core/native/juce_BasicNativeHeaders.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@
276276
#include <cpu-features.h>
277277
#endif
278278

279-
// Need to clear various moronic redefinitions made by system headers.
279+
// Need to clear various redefinitions made by system headers.
280280
#undef max
281281
#undef min
282282
#undef direct

modules/juce_core/native/juce_Threads_windows.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ void JUCE_CALLTYPE Process::terminate()
295295
_CrtDumpMemoryLeaks();
296296
#endif
297297

298-
// bullet in the head in case there's a problem shutting down
298+
// force exit in case there's a problem shutting down
299299
ExitProcess (1);
300300
}
301301

modules/juce_opengl/opengl/juce_OpenGLContext.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ class OpenGLContext::CachedImage final : public CachedComponentImage
552552
glEnable (GL_TEXTURE_2D);
553553

554554
#if JUCE_WINDOWS
555-
// some stupidly old drivers are missing this function, so try to at least avoid a crash here,
555+
// some old drivers are missing this function, so try to at least avoid a crash here,
556556
// but if you hit this assertion you may want to have your own version check before using the
557557
// component rendering stuff on such old drivers.
558558
jassert (context.extensions.glActiveTexture != nullptr);

0 commit comments

Comments
 (0)