ntfy integration with auth?

[Schachte]

I have ntfy running behind a reverse proxy and I want to enable basic auth on it.

I noticed that using custom domains with ntfy doesn't seem supported, but I was able to grab the forwarding URL to ntfy.sh from the logs, which is just the md5 hash. I have 2 questions around this:

• Does camply support custom domains for ntfy? (Do you need help adding this?)
• Does camply support ntfy push notifications for ntfy self-hosted servers behind auth? (Do you need help adding this?)

[juftin]

It would be very easy to make NTFY_ENDPOINT a camply configuration entry, this should unlock you to use self-hosted ntfy servers

camply/camply/config/notification_config.py

Lines 68 to 74 in 5ed2359

	class NtfyConfig:
	"""
	Ntfy Notification Config Class
	"""
	NTFY_API_ENDPOINT: str = "https://ntfy.sh/"
	NTFY_TOPIC = getenv("NTFY_TOPIC", None)

As far as auth goes, is that just an additional header that needs to be passed? All of the ntfy magic lies in this simple requests post

camply/camply/notifications/ntfy.py

Lines 32 to 60 in 5ed2359

	def send_message(self, message: str, **kwargs) -> requests.Response:
	"""
	Send a message via Ntfy - if environment variables are configured
	Parameters
	----------
	message: str
	Returns
	-------
	requests.Response
	"""
	response = self.session.post(
	url=NtfyConfig.NTFY_API_ENDPOINT + NtfyConfig.NTFY_TOPIC,
	data=message.encode("utf-8"),
	headers={
	"Title": kwargs.get("title", "Camply Notification"),
	"Click": kwargs.get("url", ""),
	},
	)
	try:
	response.raise_for_status()
	except requests.HTTPError as he:
	logger.warning(
	"Notifications weren't able to be sent to Ntfy. "
	"Your configuration might be incorrect."
	)
	raise ConnectionError(response.text) from he
	return response

If you're willing to help with a new PR, that would be great. Let me know - if so the original NTFY PR will be a useful reference: #248

[Schachte]

Makes sense, thanks!