Merge upstream/master into comlink-deprecation branch

Resolve conflicts:
- TeleHealthCalendarController: keep CalendarUtils import from master,
  drop bogus 'The' import
- TelehealthGlobalConfig: keep OEGlobalsBag usage from PR over raw
  $GLOBALS access
- PHPStan baselines: regenerated with composer phpstan-baseline

Author: kojiromike

.codespell-ignore-words.txt

@@ -41,7 +41,6 @@ grp
 inout
 inpt
 insid
-interpretter
 keypair
 marge
 mis
@@ -117,5 +116,4 @@ esy
 hightlight
 occurance
 seperator
-uncomplete
 vlaue

.composer-require-checker.json

@@ -1,5 +1,6 @@
 {
   "symbol-whitelist": [
+    "ADODB_mysqli_log",
     "AmcItemizedActionData",
     "Application\\Model\\ApplicationTable",
     "BillingExport",
@@ -13,6 +14,7 @@
     "IS_WINDOWS",
     "Installer\\Controller\\InstallerController",
     "Installer\\Model\\InstModuleTable",
+    "iamcal\\SQLParser",
     "Omnipay\\Common\\CreditCard",
     "Omnipay\\Omnipay",
     "OpenEMR\\Common\\Utils\\Error",
@@ -36,6 +38,7 @@
     "display_layout_tabs_data",
     "edi_generate_id",
     "edih_271_codes",
+    "eob_process_era_callback_check",
     "era_callback_check",
     "fetchEvents",
     "fixDate",
@@ -52,7 +55,6 @@
     "getPatientFullNameAsString",
     "getRegistryEntryByDirectory",
     "getSmokeCodes",
-    "getSqlLastError",
     "getUserSetting",
     "get_db",
     "get_patient_balance",

.github/actionlint.yaml

@@ -0,0 +1,22 @@
+self-hosted-runner:
+  # Labels of self-hosted runner in array of strings.
+  labels: []
+
+# Configuration variables in array of strings defined in your repository or
+# organization. `null` means disabling configuration variables check.
+# Empty array means no configuration variable is allowed.
+config-variables:
+
+# Configuration for file paths. The keys are glob patterns to match to file
+# paths relative to the repository root. The values are the configurations for
+# the file paths. Note that the path separator is always '/'.
+# The following configurations are available.
+#
+# "ignore" is an array of regular expression patterns. Matched error messages
+# are ignored. This is similar to the "-ignore" command line option.
+paths:
+  .github/workflows/database-version.yml:
+    # SC2016 warns about $ and backticks in single quotes not expanding.
+    # We intentionally use single quotes for literal markdown output.
+    ignore:
+    - SC2016

.github/actions/setup-php-composer/action.yml

@@ -0,0 +1,55 @@
+name: Setup PHP and Composer
+description: Sets up PHP, configures Composer caching, and installs dependencies
+
+inputs:
+  php-version:
+    description: PHP version to install
+    required: true
+  coverage:
+    description: Coverage driver (none, xdebug, pcov)
+    required: false
+    default: none
+  extensions:
+    description: PHP extensions to install (comma-separated)
+    required: false
+    default: ''
+  tools:
+    description: Tools to install (comma-separated, e.g., cs2pr, phpcs)
+    required: false
+    default: ''
+  skip-composer-install:
+    description: Skip Composer cache and install steps
+    required: false
+    default: 'false'
+
+runs:
+  using: composite
+  steps:
+    - name: Setup PHP
+      uses: shivammathur/setup-php@v2
+      with:
+        php-version: ${{ inputs.php-version }}
+        coverage: ${{ inputs.coverage }}
+        extensions: ${{ inputs.extensions }}
+        tools: ${{ inputs.tools }}
+
+    - name: Get composer cache directory
+      if: inputs.skip-composer-install != 'true'
+      id: composer-cache
+      shell: bash
+      run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
+
+    - name: Cache Composer dependencies
+      if: inputs.skip-composer-install != 'true'
+      uses: actions/cache@v5
+      with:
+        path: ${{ steps.composer-cache.outputs.dir }}
+        key: ${{ runner.os }}-composer-${{ inputs.php-version }}-${{ hashFiles('**/composer.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-composer-${{ inputs.php-version }}-
+          ${{ runner.os }}-composer-
+
+    - name: Install Composer dependencies
+      if: inputs.skip-composer-install != 'true'
+      shell: bash
+      run: composer install --prefer-dist --no-progress

.github/problem-matchers/phpcs.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "phpcs",
+      "pattern": [
+        {
+          "regexp": "^(.+):(\\d+):(\\d+): (error|warning) - (.+)$",
+          "file": 1,
+          "line": 2,
+          "column": 3,
+          "severity": 4,
+          "message": 5
+        }
+      ]
+    }
+  ]
+}

.github/workflows/api-docs.yml

@@ -25,51 +25,46 @@ jobs:
         php-version: ['8.2']
     name: API Docs Freshness Check
     steps:
-    - name: "Checkout Code"
+    - name: Checkout Code
       uses: actions/checkout@v6
       with:
         fetch-depth: 0
 
-    - name: "Setup PHP"
-      uses: shivammathur/setup-php@v2
+    - name: Setup PHP and Composer
+      uses: ./.github/actions/setup-php-composer
       with:
         php-version: ${{ matrix.php-version }}
-        coverage: none
 
-    - name: "Get composer cache directory"
-      id: composer-cache
-      run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT"
-
-    - name: "Composer Cache"
-      uses: actions/cache@v5
-      with:
-        path: ${{ steps.composer-cache.outputs.dir }}
-        key: ${{ runner.os }}-composer-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
-        restore-keys: |
-          ${{ runner.os }}-composer-${{ matrix.php-version }}-
-          ${{ runner.os }}-composer-
-
-    - name: "Composer Install"
-      run: composer install --prefer-dist --no-progress
-
-    - name: "Refresh API Documentation"
+    - name: Refresh API Documentation
       run: php bin/console openemr:create-api-documentation --skip-globals
 
     # If after docs regeneration there are any diff - that means docs are not in sync with new API code changes
-    - name: "Check Docs Freshness"
+    - name: Check Docs Freshness
       run: |
         if git diff --quiet; then
           echo "✅ The API documentation is in sync with the code"
           echo "# ✅ The API documentation is in sync with the code" >> "$GITHUB_STEP_SUMMARY"
           echo "\`openemr-api.yaml\` is in sync with your changes" >> "$GITHUB_STEP_SUMMARY"
           exit 0
         fi
-        echo "⚠️ The API documentation is not in sync with the code — see the Job Summary for next steps."
+        echo '⚠️ The API documentation is not in sync with the code — see the Job Summary for next steps.'
+        # shellcheck disable=SC2016
         {
-          echo "# ⚠️ The API documentation is not in sync with the code"
-          echo "Looks like \`openemr-api.yaml\` is not in sync with your changes."
-          echo "Please, run:"
-          echo "\`php bin/console openemr:create-api-documentation --skip-globals\`"
-          echo "and push updated \`openemr-api.yaml\` file into your PR"
+          echo '# ⚠️ The API documentation is not in sync with the code'
+          echo 'Looks like `openemr-api.yaml` is not in sync with your changes.'
+          echo
+          echo '## Option 1: Download the updated file'
+          echo 'Download `openemr-api.yaml` from the **Artifacts** section of this workflow run and commit it to your PR.'
+          echo
+          echo '## Option 2: Regenerate locally'
+          echo 'Run `php bin/console openemr:create-api-documentation --skip-globals` and push the updated file.'
         } >> "$GITHUB_STEP_SUMMARY"
         exit 1
+
+    - name: Upload updated API docs
+      if: failure()
+      uses: actions/upload-artifact@v7
+      with:
+        name: openemr-api-yaml
+        path: swagger/openemr-api.yaml
+        retention-days: 14

.github/workflows/codecov-notify.yml

@@ -33,102 +33,15 @@ concurrency:
 jobs:
   composer-require-checker:
     runs-on: ubuntu-24.04
-    strategy:
-      matrix:
-        php-version:
-        - '8.2'
-        composer-require-checker-version:
-        - 4.16.1
     steps:
     - name: Checkout Code
       uses: actions/checkout@v6
 
     - name: Setup PHP
-      uses: shivammathur/setup-php@v2
+      uses: ./.github/actions/setup-php-composer
       with:
-        php-version: ${{ matrix.php-version }}
+        php-version: '8.2'
         extensions: bcmath, calendar, ctype, curl, dom, fileinfo, filter, gd, iconv, imagick, intl, json, ldap, libxml, mbstring, mysqli, openssl, pdo, pdo_mysql, phar, session, simplexml, soap, sockets, sodium, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, zlib
-        coverage: none
-
-    - name: Get composer cache directory
-      id: composer-cache
-      run: |
-        {
-          printf 'dir='
-          composer config cache-files-dir
-        } >> "$GITHUB_OUTPUT"
-
-    ##
-    # These are reused a bunch so it's neater to collect them here
-    - name: Collect cache keys
-      id: cache-keys
-      run: |
-        {
-          echo 'vendor=${{ runner.os }}-vendor-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}'
-          echo 'composer=${{ runner.os }}-composer-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}'
-        } >> "$GITHUB_OUTPUT"
-
-    - name: Restore vendor artifacts
-      id: vendor-cache-restore
-      uses: actions/cache/restore@v5
-      with:
-        key: ${{ steps.cache-keys.outputs.vendor }}
-        path: vendor/
-        restore-keys: |
-          ${{ runner.os }}-vendor-${{ matrix.php-version }}-
-          ${{ runner.os }}-vendor-
-
-    - name: Check vendor artifacts cache
-      id: vendor-cache-check
-      run: |
-        key='${{ steps.cache-keys.outputs.vendor }}'
-        matched='${{ steps.vendor-cache-restore.outputs.cache-matched-key }}'
-        if [[ $key = "$matched" ]]; then
-          echo hit=true
-        else
-          echo hit=false
-        fi >> "$GITHUB_OUTPUT"
-
-    - name: Restore composer downloads
-      id: composer-cache-restore
-      if: ${{ steps.vendor-cache-check.outputs.hit != 'true' }}
-      uses: actions/cache/restore@v5
-      with:
-        key: ${{ steps.cache-keys.outputs.composer }}
-        path: ${{ steps.composer-cache.outputs.dir }}
-        restore-keys: |
-          ${{ runner.os }}-composer-${{ matrix.php-version }}-
-          ${{ runner.os }}-composer-
-
-    - name: Composer Install
-      if: ${{ steps.vendor-cache-check.outputs.hit != 'true' }}
-      run: composer install --prefer-dist --no-progress
-
-    - name: Save composer cache
-      if: ${{ steps.vendor-cache-check.outputs.hit != 'true' }}
-      uses: actions/cache/save@v5
-      with:
-        key: ${{ runner.os }}-composer-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
-        path: ${{ steps.composer-cache.outputs.dir }}
-
-    - name: Save vendor artifacts
-      if: ${{ steps.vendor-cache-check.outputs.hit != 'true' }}
-      uses: actions/cache/save@v5
-      with:
-        key: ${{ runner.os }}-vendor-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
-        path: vendor/
-
-    - name: Download Composer Require Checker
-      run: |
-        version=${{ matrix.composer-require-checker-version }}
-        echo "Downloading composer-require-checker version: $version"
-        curl -fsSLo composer-require-checker.phar "https://github.com/maglnet/ComposerRequireChecker/releases/download/${version}/composer-require-checker.phar"
 
     - name: Run Composer Require Checker
-      shell: bash
-      run: |
-        if [[ -f .composer-require-checker.json ]]; then
-          php composer-require-checker.phar check --config-file=.composer-require-checker.json composer.json
-        else
-          php composer-require-checker.phar check composer.json
-        fi
+      run: composer require-checker