fix long warmup name (#71)

Author: zxh326

internal/controller/warmup_controller.go

@@ -156,7 +156,7 @@ func (o *onceHandler) sync(ctx context.Context, wu *juicefsiov1.WarmUp, cgName s
 		}
 		return reconcile.Result{}, nil
 	}
-	jobName := common.GenJobName(wu.Name)
+	jobName := utils.GenJobName(wu.Name)
 	var job batchv1.Job
 	if err := o.Get(ctx, client.ObjectKey{Namespace: wu.Namespace, Name: jobName}, &job); err != nil {
 		if utils.IsNotFound(err) {
@@ -271,7 +271,7 @@ func (c *cronHandler) sync(ctx context.Context, wu *juicefsiov1.WarmUp, cgName s
 	cronjobBuilder := builder.NewJobBuilder(wu, &podList.Items[0])
 	newCronJob := cronjobBuilder.NewWarmUpCronJob()
 
-	if err := c.Get(ctx, client.ObjectKey{Namespace: wu.Namespace, Name: common.GenJobName(wu.Name)}, &cronjob); err != nil {
+	if err := c.Get(ctx, client.ObjectKey{Namespace: wu.Namespace, Name: newCronJob.Name}, &cronjob); err != nil {
 		if utils.IsNotFound(err) {
 			l.Info("create warmup cronjob", "cronjob", newCronJob.Name)
 			err = c.Create(ctx, newCronJob)

internal/controller/warmup_controller_test.go

@@ -30,6 +30,7 @@ import (
 
 	juicefsiov1 "github.com/juicedata/juicefs-operator/api/v1"
 	"github.com/juicedata/juicefs-operator/pkg/common"
+	"github.com/juicedata/juicefs-operator/pkg/utils"
 )
 
 var _ = Describe("WarmUp Controller", func() {
@@ -156,7 +157,7 @@ var _ = Describe("WarmUp Controller", func() {
 			job := &batchv1.Job{}
 			err = k8sClient.Get(ctx, types.NamespacedName{
 				Namespace: namespace,
-				Name:      common.GenJobName(warmup.Name),
+				Name:      utils.GenJobName(warmup.Name),
 			}, job)
 			Expect(err).NotTo(HaveOccurred())
 		})

pkg/builder/job.go

@@ -90,7 +90,7 @@ func (j *JobBuilder) NewWarmUpCronJob() *batchv1.CronJob {
 
 	cronJob := &batchv1.CronJob{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:            common.GenJobName(j.wu.Name),
+			Name:            utils.GenCronJobName(j.wu.Name),
 			Namespace:       j.wu.Namespace,
 			OwnerReferences: GetWarmUpOwnerReference(j.wu),
 			Labels: map[string]string{
@@ -124,7 +124,7 @@ func (j *JobBuilder) NewWarmUpCronJob() *batchv1.CronJob {
 func (j *JobBuilder) genBaseJob() *batchv1.Job {
 	job := &batchv1.Job{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:            common.GenJobName(j.wu.Name),
+			Name:            utils.GenJobName(j.wu.Name),
 			Namespace:       j.wu.Namespace,
 			OwnerReferences: GetWarmUpOwnerReference(j.wu),
 			Labels: map[string]string{

pkg/common/common.go

@@ -66,7 +66,8 @@ const (
 	AnnoBackupWorker        = "juicefs.io/backup-worker"
 	AnnoWaitingDeleteWorker = "juicefs.io/waiting-delete-worker"
 
-	LabelMaxLength = 63
+	LabelMaxLength       = 63
+	CronJobNameMaxLength = 52
 
 	InitConfigVolumeName = "init-config"
 	InitConfigVolumeKey  = "initconfig"
@@ -118,10 +119,6 @@ func GenWorkerName(cgName string, nodeName string) string {
 	return fmt.Sprintf("%s-%s-%s", WorkerNamePrefix, cgName, nodeName)
 }
 
-func GenJobName(wuName string) string {
-	return fmt.Sprintf("%s-%s", WarmUpNamePrefix, wuName)
-}
-
 func GenCleanCacheJobName(cgName, nodeName string) string {
 	return fmt.Sprintf("%s-%s-%s", CleanCacheContainerName, cgName, nodeName)
 }

pkg/utils/job.go

@@ -17,8 +17,10 @@
 package utils
 
 import (
+	"fmt"
 	"time"
 
+	"github.com/juicedata/juicefs-operator/pkg/common"
 	v1 "k8s.io/api/batch/v1"
 )
 
@@ -39,3 +41,13 @@ func CalculateDuration(creationTime time.Time, finishTime time.Time) string {
 	}
 	return finishTime.Sub(creationTime).Round(time.Second).String()
 }
+
+func GenJobName(wuName string) string {
+	n := fmt.Sprintf("%s-%s", common.WarmUpNamePrefix, wuName)
+	return TruncateLabelValue(n)
+}
+
+func GenCronJobName(wuName string) string {
+	n := fmt.Sprintf("%s-%s", common.WarmUpNamePrefix, wuName)
+	return TruncateLabelValueWithLength(n, common.CronJobNameMaxLength)
+}

pkg/utils/utils.go

@@ -146,7 +146,10 @@ func ParseYamlOrJson(source string) (map[string]interface{}, error) {
 // If the input string is longer than the maximum length, it computes an MD5 hash of
 // the string, and appends it to the input string
 func TruncateLabelValue(s string) string {
-	length := common.LabelMaxLength
+	return TruncateLabelValueWithLength(s, common.LabelMaxLength)
+}
+
+func TruncateLabelValueWithLength(s string, length int) string {
 	if len(s) <= length {
 		return s
 	}

test/e2e/e2e_test.go

@@ -29,6 +29,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 
 	"github.com/juicedata/juicefs-operator/pkg/common"
+	pkgutils "github.com/juicedata/juicefs-operator/pkg/utils"
 	"github.com/juicedata/juicefs-operator/test/utils"
 )
 
@@ -771,7 +772,7 @@ var _ = Describe("controller", Ordered, func() {
 			fmt.Println("pods:")
 			fmt.Println(string(result))
 
-			cmd = exec.Command("kubectl", "get", "po", "-l", fmt.Sprintf("job-name=%s", common.GenJobName(wuName)), "-n", namespace, "--no-headers", "-o", "jsonpath='{.items[*].metadata.name}'")
+			cmd = exec.Command("kubectl", "get", "po", "-l", fmt.Sprintf("job-name=%s", pkgutils.GenJobName(wuName)), "-n", namespace, "--no-headers", "-o", "jsonpath='{.items[*].metadata.name}'")
 			result, _ = utils.Run(cmd)
 			if len(utils.GetNonEmptyLines(string(result))) == 1 && strings.TrimSpace(string(result)) != "''" {
 				fmt.Println("warmup pod describe:")
@@ -817,7 +818,7 @@ var _ = Describe("controller", Ordered, func() {
 
 			By("validating warmup job running")
 			verifyWarmUpJobRunning := func() error {
-				cmd := exec.Command("kubectl", "get", "job", common.GenJobName(wuName), "-n", namespace, "-o", "jsonpath={.status.active}")
+				cmd := exec.Command("kubectl", "get", "job", pkgutils.GenJobName(wuName), "-n", namespace, "-o", "jsonpath={.status.active}")
 				result, err := utils.Run(cmd)
 				if err != nil {
 					return fmt.Errorf("get warmup job failed, %+v", err)
@@ -839,7 +840,7 @@ var _ = Describe("controller", Ordered, func() {
 				if string(status) != "Running" {
 					return fmt.Errorf("warmup in %s status", status)
 				}
-				cmd = exec.Command("kubectl", "get", "po", "-l", fmt.Sprintf("job-name=%s", common.GenJobName(wuName)), "-n", namespace, "--no-headers")
+				cmd = exec.Command("kubectl", "get", "po", "-l", fmt.Sprintf("job-name=%s", pkgutils.GenJobName(wuName)), "-n", namespace, "--no-headers")
 				result, err := utils.Run(cmd)
 				if err != nil {
 					return fmt.Errorf("get warmup job pod failed, %+v", err)