Skip to content

Commit c6833e4

Browse files
authored
Fix test arguments in test_dylink_dso_needed (emscripten-core#25815)
I fixed the arguments so the non-worker version of this test now runs, but sadly is currently failing so I opened emscripten-core#25814
1 parent 55aef98 commit c6833e4

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

test/test_browser.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3636,11 +3636,12 @@ def test_dlopen_blocking(self):
36363636
# verify that dynamic linking works in all kinds of in-browser environments.
36373637
# don't mix different kinds in a single test.
36383638
@parameterized({
3639-
'': ([0],),
3640-
'inworker': ([1],),
3639+
'': (0,),
3640+
'inworker': (1,),
36413641
})
36423642
def test_dylink_dso_needed(self, inworker):
3643-
self.cflags += ['-O2']
3643+
if not inworker:
3644+
self.skipTest('https://github.com/emscripten-core/emscripten/issues/25814')
36443645

36453646
def do_run(src, expected_output, cflags):
36463647
# XXX there is no infrastructure (yet ?) to retrieve stdout from browser in tests.
@@ -3670,7 +3671,7 @@ def do_run(src, expected_output, cflags):
36703671
return rtn;
36713672
}
36723673
''' % expected_output)
3673-
# --proxy-to-worker only on main
3674+
# --proxy-to-worker only when linking the main module
36743675
if inworker:
36753676
cflags += ['--proxy-to-worker', '-Wno-deprecated']
36763677
self.btest_exit('test_dylink_dso_needed.c', cflags=['--post-js', 'post.js'] + cflags)

0 commit comments

Comments
 (0)