TextDecoder defaults to utf-8. NFC (emscripten-core#22078)

sbc100 · web-flow · commit ebe6f8375b63 · 2024-06-10T14:56:03.000-07:00
diff --git a/src/library_strings.js b/src/library_strings.js
@@ -7,10 +7,11 @@
 #include "arrayUtils.js"
 
 addToLibrary({
+  // TextDecoder constructor defaults to UTF-8
 #if TEXTDECODER == 2
-  $UTF8Decoder: "new TextDecoder('utf8')",
+  $UTF8Decoder: "new TextDecoder()",
 #elif TEXTDECODER == 1
-  $UTF8Decoder: "typeof TextDecoder != 'undefined' ? new TextDecoder('utf8') : undefined",
+  $UTF8Decoder: "typeof TextDecoder != 'undefined' ? new TextDecoder() : undefined",
 #endif
 
   $UTF8ArrayToString__docs: `
diff --git a/test/code_size/embind_val_wasm.json b/test/code_size/embind_val_wasm.json
@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 380,
-  "a.js": 7080,
-  "a.js.gz": 2999,
+  "a.js": 7072,
+  "a.js.gz": 2997,
   "a.wasm": 11618,
   "a.wasm.gz": 5811,
-  "total": 19250,
-  "total_gz": 9190
+  "total": 19242,
+  "total_gz": 9188
 }
diff --git a/test/code_size/hello_webgl2_wasm.json b/test/code_size/hello_webgl2_wasm.json
@@ -1,10 +1,10 @@
 {
   "a.html": 454,
   "a.html.gz": 328,
-  "a.js": 4539,
-  "a.js.gz": 2315,
+  "a.js": 4531,
+  "a.js.gz": 2309,
   "a.wasm": 10439,
   "a.wasm.gz": 6728,
-  "total": 15432,
-  "total_gz": 9371
+  "total": 15424,
+  "total_gz": 9365
 }
diff --git a/test/code_size/hello_webgl2_wasm2js.json b/test/code_size/hello_webgl2_wasm2js.json
@@ -1,8 +1,8 @@
 {
   "a.html": 346,
   "a.html.gz": 262,
-  "a.js": 22196,
-  "a.js.gz": 11586,
-  "total": 22542,
-  "total_gz": 11848
+  "a.js": 22188,
+  "a.js.gz": 11580,
+  "total": 22534,
+  "total_gz": 11842
 }
diff --git a/test/code_size/hello_webgl_wasm.json b/test/code_size/hello_webgl_wasm.json
@@ -1,10 +1,10 @@
 {
   "a.html": 454,
   "a.html.gz": 328,
-  "a.js": 4056,
-  "a.js.gz": 2152,
+  "a.js": 4048,
+  "a.js.gz": 2147,
   "a.wasm": 10439,
   "a.wasm.gz": 6728,
-  "total": 14949,
-  "total_gz": 9208
+  "total": 14941,
+  "total_gz": 9203
 }
diff --git a/test/code_size/hello_webgl_wasm2js.json b/test/code_size/hello_webgl_wasm2js.json
@@ -1,8 +1,8 @@
 {
   "a.html": 346,
   "a.html.gz": 262,
-  "a.js": 21698,
-  "a.js.gz": 11410,
-  "total": 22044,
-  "total_gz": 11672
+  "a.js": 21690,
+  "a.js.gz": 11405,
+  "total": 22036,
+  "total_gz": 11667
 }
diff --git a/test/code_size/hello_world_wasm.js b/test/code_size/hello_world_wasm.js
@@ -1,4 +1,4 @@
-var d = Module, e, f, g = new TextDecoder("utf8"), h;
+var d = Module, e, f, g = new TextDecoder, h;
 
 WebAssembly.instantiate(d.wasm, {
     a: {
diff --git a/test/code_size/hello_world_wasm.json b/test/code_size/hello_world_wasm.json
@@ -1,10 +1,10 @@
 {
   "a.html": 552,
   "a.html.gz": 380,
-  "a.js": 291,
-  "a.js.gz": 249,
+  "a.js": 283,
+  "a.js.gz": 244,
   "a.wasm": 103,
   "a.wasm.gz": 113,
-  "total": 946,
-  "total_gz": 742
+  "total": 938,
+  "total_gz": 737
 }
diff --git a/test/code_size/hello_world_wasm2js.js b/test/code_size/hello_world_wasm2js.js
@@ -1,4 +1,4 @@
-var d = Module, g, h, k = new TextDecoder("utf8"), l;
+var d = Module, g, h, k = new TextDecoder, l;
 
 function e(b) {
     this.exports = function(r) {
diff --git a/test/code_size/hello_world_wasm2js.json b/test/code_size/hello_world_wasm2js.json
@@ -1,8 +1,8 @@
 {
   "a.html": 323,
   "a.html.gz": 253,
-  "a.js": 1060,
-  "a.js.gz": 636,
-  "total": 1383,
-  "total_gz": 889
+  "a.js": 1052,
+  "a.js.gz": 630,
+  "total": 1375,
+  "total_gz": 883
 }
diff --git a/test/code_size/random_printf_wasm.json b/test/code_size/random_printf_wasm.json
@@ -1,6 +1,6 @@
 {
-  "a.html": 12742,
-  "a.html.gz": 6928,
-  "total": 12742,
-  "total_gz": 6928
+  "a.html": 12734,
+  "a.html.gz": 6921,
+  "total": 12734,
+  "total_gz": 6921
 }
diff --git a/test/code_size/random_printf_wasm2js.json b/test/code_size/random_printf_wasm2js.json
@@ -1,6 +1,6 @@
 {
-  "a.html": 17329,
-  "a.html.gz": 7518,
-  "total": 17329,
-  "total_gz": 7518
+  "a.html": 17321,
+  "a.html.gz": 7511,
+  "total": 17321,
+  "total_gz": 7511
 }
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.gzsize b/test/other/metadce/test_metadce_cxx_ctors1.gzsize
@@ -1 +1 @@
-9805
+9802
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.jssize b/test/other/metadce/test_metadce_cxx_ctors1.jssize
@@ -1 +1 @@
-24088
+24080
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.gzsize b/test/other/metadce/test_metadce_cxx_ctors2.gzsize
@@ -1 +1 @@
-9789
+9786
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.jssize b/test/other/metadce/test_metadce_cxx_ctors2.jssize
@@ -1 +1 @@
-24056
+24048
diff --git a/test/other/metadce/test_metadce_cxx_except.gzsize b/test/other/metadce/test_metadce_cxx_except.gzsize
@@ -1 +1 @@
-10886
+10884
diff --git a/test/other/metadce/test_metadce_cxx_except.jssize b/test/other/metadce/test_metadce_cxx_except.jssize
@@ -1 +1 @@
-27994
+27986
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm.gzsize b/test/other/metadce/test_metadce_cxx_except_wasm.gzsize
@@ -1 +1 @@
-9768
+9765
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm.jssize b/test/other/metadce/test_metadce_cxx_except_wasm.jssize
@@ -1 +1 @@
-23981
+23973
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm_exnref.gzsize b/test/other/metadce/test_metadce_cxx_except_wasm_exnref.gzsize
@@ -1 +1 @@
-9768
+9765
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm_exnref.jssize b/test/other/metadce/test_metadce_cxx_except_wasm_exnref.jssize
@@ -1 +1 @@
-23981
+23973
diff --git a/test/other/metadce/test_metadce_cxx_mangle.gzsize b/test/other/metadce/test_metadce_cxx_mangle.gzsize
@@ -1 +1 @@
-10891
+10888
diff --git a/test/other/metadce/test_metadce_cxx_mangle.jssize b/test/other/metadce/test_metadce_cxx_mangle.jssize
@@ -1 +1 @@
-27994
+27986
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.gzsize b/test/other/metadce/test_metadce_cxx_noexcept.gzsize
@@ -1 +1 @@
-9805
+9802
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.jssize b/test/other/metadce/test_metadce_cxx_noexcept.jssize
@@ -1 +1 @@
-24088
+24080
diff --git a/test/other/metadce/test_metadce_cxx_wasmfs.gzsize b/test/other/metadce/test_metadce_cxx_wasmfs.gzsize
@@ -1 +1 @@
-5171
+5168
diff --git a/test/other/metadce/test_metadce_cxx_wasmfs.jssize b/test/other/metadce/test_metadce_cxx_wasmfs.jssize
@@ -1 +1 @@
-11916
+11908
diff --git a/test/other/metadce/test_metadce_files_js_fs.gzsize b/test/other/metadce/test_metadce_files_js_fs.gzsize
@@ -1 +1 @@
-7753
+7748
diff --git a/test/other/metadce/test_metadce_files_js_fs.jssize b/test/other/metadce/test_metadce_files_js_fs.jssize
@@ -1 +1 @@
-19112
+19104
diff --git a/test/other/metadce/test_metadce_files_wasmfs.gzsize b/test/other/metadce/test_metadce_files_wasmfs.gzsize
@@ -1 +1 @@
-3079
+3078
diff --git a/test/other/metadce/test_metadce_files_wasmfs.jssize b/test/other/metadce/test_metadce_files_wasmfs.jssize
@@ -1 +1 @@
-6666
+6657
diff --git a/test/other/metadce/test_metadce_hello_O0.gzsize b/test/other/metadce/test_metadce_hello_O0.gzsize
@@ -1 +1 @@
-8084
+8081
diff --git a/test/other/metadce/test_metadce_hello_O0.jssize b/test/other/metadce/test_metadce_hello_O0.jssize
@@ -1 +1 @@
-21833
+21827
diff --git a/test/other/metadce/test_metadce_hello_O1.gzsize b/test/other/metadce/test_metadce_hello_O1.gzsize
@@ -1 +1 @@
-2913
+2910
diff --git a/test/other/metadce/test_metadce_hello_O1.jssize b/test/other/metadce/test_metadce_hello_O1.jssize
@@ -1 +1 @@
-7474
+7468
diff --git a/test/other/metadce/test_metadce_hello_O2.gzsize b/test/other/metadce/test_metadce_hello_O2.gzsize
@@ -1 +1 @@
-2579
+2575
diff --git a/test/other/metadce/test_metadce_hello_O2.jssize b/test/other/metadce/test_metadce_hello_O2.jssize
@@ -1 +1 @@
-5356
+5348
diff --git a/test/other/metadce/test_metadce_hello_O3.gzsize b/test/other/metadce/test_metadce_hello_O3.gzsize
@@ -1 +1 @@
-2497
+2494
diff --git a/test/other/metadce/test_metadce_hello_O3.jssize b/test/other/metadce/test_metadce_hello_O3.jssize
@@ -1 +1 @@
-5202
+5194
diff --git a/test/other/metadce/test_metadce_hello_Os.gzsize b/test/other/metadce/test_metadce_hello_Os.gzsize
@@ -1 +1 @@
-2497
+2494
diff --git a/test/other/metadce/test_metadce_hello_Os.jssize b/test/other/metadce/test_metadce_hello_Os.jssize
@@ -1 +1 @@
-5202
+5194
diff --git a/test/other/metadce/test_metadce_hello_Oz.gzsize b/test/other/metadce/test_metadce_hello_Oz.gzsize
@@ -1 +1 @@
-2475
+2471
diff --git a/test/other/metadce/test_metadce_hello_Oz.jssize b/test/other/metadce/test_metadce_hello_Oz.jssize
@@ -1 +1 @@
-5169
+5161
diff --git a/test/other/metadce/test_metadce_hello_dylink.gzsize b/test/other/metadce/test_metadce_hello_dylink.gzsize
@@ -1 +1 @@
-6392
+6388
diff --git a/test/other/metadce/test_metadce_hello_dylink.jssize b/test/other/metadce/test_metadce_hello_dylink.jssize
@@ -1 +1 @@
-14185
+14177
diff --git a/test/other/metadce/test_metadce_hello_wasmfs.gzsize b/test/other/metadce/test_metadce_hello_wasmfs.gzsize
@@ -1 +1 @@
-2497
+2494
diff --git a/test/other/metadce/test_metadce_hello_wasmfs.jssize b/test/other/metadce/test_metadce_hello_wasmfs.jssize
@@ -1 +1 @@
-5202
+5194
diff --git a/test/other/metadce/test_metadce_minimal_pthreads.gzsize b/test/other/metadce/test_metadce_minimal_pthreads.gzsize
@@ -1 +1 @@
-5214
+5210
diff --git a/test/other/metadce/test_metadce_minimal_pthreads.jssize b/test/other/metadce/test_metadce_minimal_pthreads.jssize
@@ -1 +1 @@
-11382
+11374
diff --git a/test/other/test_unoptimized_code_size.js.size b/test/other/test_unoptimized_code_size.js.size
@@ -1 +1 @@
-55439
+55433
diff --git a/test/other/test_unoptimized_code_size_no_asserts.js.size b/test/other/test_unoptimized_code_size_no_asserts.js.size
@@ -1 +1 @@
-31339
+31333
diff --git a/test/other/test_unoptimized_code_size_strict.js.size b/test/other/test_unoptimized_code_size_strict.js.size
@@ -1 +1 @@
-54302
+54296

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"a.html": 346,`
`3`	`3`	`"a.html.gz": 262,`
`4`		`- "a.js": 22196,`
`5`		`- "a.js.gz": 11586,`
`6`		`- "total": 22542,`
`7`		`- "total_gz": 11848`
	`4`	`+ "a.js": 22188,`
	`5`	`+ "a.js.gz": 11580,`
	`6`	`+ "total": 22534,`
	`7`	`+ "total_gz": 11842`
`8`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-var d = Module, e, f, g = new TextDecoder("utf8"), h;`
	`1`	`+var d = Module, e, f, g = new TextDecoder, h;`
`2`	`2`
`3`	`3`	`WebAssembly.instantiate(d.wasm, {`
`4`	`4`	`a: {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-var d = Module, g, h, k = new TextDecoder("utf8"), l;`
	`1`	`+var d = Module, g, h, k = new TextDecoder, l;`
`2`	`2`
`3`	`3`	`function e(b) {`
`4`	`4`	`this.exports = function(r) {`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"a.html": 323,`
`3`	`3`	`"a.html.gz": 253,`
`4`		`- "a.js": 1060,`
`5`		`- "a.js.gz": 636,`
`6`		`- "total": 1383,`
`7`		`- "total_gz": 889`
	`4`	`+ "a.js": 1052,`
	`5`	`+ "a.js.gz": 630,`
	`6`	`+ "total": 1375,`
	`7`	`+ "total_gz": 883`
`8`	`8`	`}`