Skip to content

Review filter state persists across app launches via @AppStorage #5

@jukasdrj

Description

@jukasdrj

Description

The review filter toggle (⚠️ button) uses @AppStorage("show_review_needed") which persists to UserDefaults. If a user accidentally activates this filter, the library shows "No books need review" on every subsequent app launch until they figure out how to toggle it off.

Impact

Location

swiftwing/LibraryView.swift:49

@AppStorage("show_review_needed") private var showReviewNeeded = false

Suggested Fix

Change @AppStorage to @State so the filter resets on each launch:

@State private var showReviewNeeded = false

Or alternatively, add a clear visual indicator and easy dismiss (e.g., banner "Showing filtered results" with an X button).

Found During

E2E simulator testing (Phase 2: Library tab tests)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions