-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Description
The review filter toggle (@AppStorage("show_review_needed") which persists to UserDefaults. If a user accidentally activates this filter, the library shows "No books need review" on every subsequent app launch until they figure out how to toggle it off.
Impact
- Users can get stuck in a confusing state showing no books
- Combined with Issue Library toolbar: review filter button too easy to accidentally activate #3 (easy to accidentally activate), this creates a poor UX
- Filter state survives app termination and relaunch
Location
swiftwing/LibraryView.swift:49
@AppStorage("show_review_needed") private var showReviewNeeded = falseSuggested Fix
Change @AppStorage to @State so the filter resets on each launch:
@State private var showReviewNeeded = falseOr alternatively, add a clear visual indicator and easy dismiss (e.g., banner "Showing filtered results" with an X button).
Found During
E2E simulator testing (Phase 2: Library tab tests)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working