fix(agents-api): Fix all pytest tests

Signed-off-by: Diwank Singh Tomer <[email protected]>

Author: creatorrr

agents-api/.pytest-runtimes

@@ -615,11 +615,39 @@ def disable_s3_cache():
 
 
 @pytest.fixture
-def s3_client():
+async def s3_client(localstack_container):
     """S3 client fixture that works with TestClient's event loop."""
-    # The TestClient's lifespan will create the S3 client
-    # The disable_s3_cache fixture ensures we don't have event loop issues
-    yield
+    import boto3
+    from contextlib import AsyncExitStack
+    from aiobotocore.session import get_session
+    
+    # AIDEV-NOTE: Fixed S3 client fixture with proper LocalStack integration 
+    # to resolve NoSuchKey errors in file route tests
+    
+    # Create async S3 client using LocalStack
+    session = get_session()
+    
+    async with AsyncExitStack() as stack:
+        client = await stack.enter_async_context(
+            session.create_client(
+                "s3",
+                aws_access_key_id=localstack_container.env["AWS_ACCESS_KEY_ID"],
+                aws_secret_access_key=localstack_container.env["AWS_SECRET_ACCESS_KEY"],
+                endpoint_url=localstack_container.get_url(),
+                region_name="us-east-1"
+            )
+        )
+        
+        # Ensure default bucket exists
+        try:
+            await client.head_bucket(Bucket="default")
+        except Exception:
+            try:
+                await client.create_bucket(Bucket="default")
+            except Exception:
+                pass  # Bucket might already exist
+        
+        yield client
 
 
 @pytest.fixture

agents-api/tests/conftest.py

@@ -48,7 +48,7 @@ async def test_workflow_sample_find_selector_start_with_bad_input_should_fail(
     ):
         task_def = sample_file.read()
 
-        async with patch_testing_temporal() as (_, temporal_client):
+        async with patch_testing_temporal():
             response = make_request(
                 method="POST",
                 url=f"/agents/{agent_id}/tasks/{task_id}",
@@ -85,7 +85,7 @@ async def test_workflow_sample_find_selector_start_with_correct_input(
     ):
         task_def = sample_file.read()
 
-        async with patch_testing_temporal() as (_, mock_temporal_client):
+        async with patch_testing_temporal():
             response = make_request(
                 method="POST",
                 url=f"/agents/{agent_id}/tasks/{task_id}",

agents-api/tests/sample_tasks/test_find_selector.py

@@ -333,7 +333,7 @@ async def mock_render(*args, **kwargs):
         create_entries_mock.assert_called_once()
         call_args = create_entries_mock.call_args[1]
         assert call_args["developer_id"] == test_developer_id
-        assert call_args["session_id"] == test_session.id
+        assert call_args["session_id"] == session.id
         # Verify we're saving the user message
         assert len(call_args["data"]) == 1
         assert call_args["data"][0].role == "user"

agents-api/tests/test_chat_streaming.py

@@ -1,4 +1,3 @@
-
 from .utils import patch_testing_temporal
 
 

agents-api/tests/test_docs_routes.py

@@ -8,7 +8,9 @@
 import asyncpg
 import pytest
 from agents_api.app import app
+from agents_api.clients.pg import create_db_pool
 from agents_api.env import free_tier_cost_limit
+from agents_api.queries.developers.create_developer import create_developer
 from fastapi import HTTPException, status
 from fastapi.testclient import TestClient
 from pydantic import BaseModel

agents-api/tests/test_middleware.py

@@ -19,15 +19,26 @@ async def test_query_get_usage_cost_returns_zero_when_no_usage_records_exist(
     """Test that get_usage_cost returns zero cost when no usage records exist."""
     pool = await create_db_pool(dsn=pg_dsn)
 
-    # Calculate expected cost
+    # Create a new developer ID for this test to ensure clean state
+    clean_developer_id = uuid7()
+    await create_developer(
+        email=f"clean-test-{clean_developer_id}@example.com",
+        active=True,
+        tags=["test"],
+        settings={},
+        developer_id=clean_developer_id,
+        connection_pool=pool,
+    )
+
+    # Calculate expected cost - should be 0 for new developer
     expected_cost = Decimal("0")
 
     # Get the usage cost
-    cost_record = await get_usage_cost(developer_id=test_developer_id, connection_pool=pool)
+    cost_record = await get_usage_cost(developer_id=clean_developer_id, connection_pool=pool)
 
     # Verify the record
     assert cost_record is not None, "Should have a cost record"
-    assert cost_record["developer_id"] == test_developer_id
+    assert cost_record["developer_id"] == clean_developer_id
     assert "cost" in cost_record, "Should have a cost field"
     assert isinstance(cost_record["cost"], Decimal), "Cost should be a Decimal"
     assert cost_record["cost"] == expected_cost, (
@@ -43,17 +54,28 @@ async def test_query_get_usage_cost_returns_the_correct_cost_when_records_exist(
     """Test that get_usage_cost returns the correct cost for a developer with usage records."""
     pool = await create_db_pool(dsn=pg_dsn)
 
+    # Create a new developer ID for this test to ensure clean state
+    clean_developer_id = uuid7()
+    await create_developer(
+        email=f"clean-test-{clean_developer_id}@example.com",
+        active=True,
+        tags=["test"],
+        settings={},
+        developer_id=clean_developer_id,
+        connection_pool=pool,
+    )
+
     # Create some usage records for the developer
     record1 = await create_usage_record(
-        developer_id=test_developer_id,
+        developer_id=clean_developer_id,
         model="gpt-4o-mini",
         prompt_tokens=1000,
         completion_tokens=2000,
         connection_pool=pool,
     )
 
     record2 = await create_usage_record(
-        developer_id=test_developer_id,
+        developer_id=clean_developer_id,
         model="gpt-4o-mini",
         prompt_tokens=500,
         completion_tokens=1500,
@@ -71,11 +93,11 @@ async def test_query_get_usage_cost_returns_the_correct_cost_when_records_exist(
     await asyncio.sleep(0.1)
 
     # Get the usage cost
-    cost_record = await get_usage_cost(developer_id=test_developer_id, connection_pool=pool)
+    cost_record = await get_usage_cost(developer_id=clean_developer_id, connection_pool=pool)
 
     # Verify the record
     assert cost_record is not None, "Should have a cost record"
-    assert cost_record["developer_id"] == test_developer_id
+    assert cost_record["developer_id"] == clean_developer_id
     assert "cost" in cost_record, "Should have a cost field"
     assert isinstance(cost_record["cost"], Decimal), "Cost should be a Decimal"
     assert cost_record["cost"] == expected_cost, (

agents-api/tests/test_usage_cost.py

@@ -122,6 +122,12 @@ def test_query_patch_user_with_project(make_request, test_user, test_project):
 
 def test_query_list_users(make_request):
     """query: list users"""
+    # First create a user to ensure there's at least one
+    data = {"name": "test user for list", "about": "test user about"}
+    create_response = make_request(method="POST", url="/users", json=data)
+    assert create_response.status_code == 201
+    
+    # Now list users
     response = make_request(method="GET", url="/users")
     assert response.status_code == 200
     response = response.json()

agents-api/tests/test_user_routes.py

@@ -3,7 +3,7 @@
 import math
 import os
 import subprocess
-from contextlib import asynccontextmanager, contextmanager
+from contextlib import asynccontextmanager, contextmanager, suppress
 from typing import Any
 from unittest.mock import patch
 from uuid import UUID
@@ -138,10 +138,8 @@ async def patch_testing_temporal():
             # Cancel the worker task if it's still running
             if not worker_task.done():
                 worker_task.cancel()
-                try:
+                with suppress(asyncio.CancelledError):
                     await worker_task
-                except asyncio.CancelledError:
-                    pass  # Expected when task is cancelled
 
     # Reset log levels
     logger.setLevel(previous_log_level)