-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
performanceCPU, RAM, disk utilization and efficiencyCPU, RAM, disk utilization and efficiencyquestionFurther information is requestedFurther information is requested
Description
We should be able to use @nospecialize on the arguments to Salsa derived functions and input functions, because the code should be entirely unchanged no matter what the type of the argument is: look it up then get it out of the dictionary.
But when we tried adding it, we either didn't see any affect at all, or sometimes it even got slower, maybe?
We should do a thorough investigation here and settle on the right answer.
This one doesn't have a TODO, but i also don't really know if it's doing anything:
https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/Salsa.jl#L608-L609
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
performanceCPU, RAM, disk utilization and efficiencyCPU, RAM, disk utilization and efficiencyquestionFurther information is requestedFurther information is requested