Skip to content

Commit ee65f6d

Browse files
disable ReplaceStringCasingWithInsensitiveRegexMatch rule in 8.19
1 parent e4042fd commit ee65f6d

File tree

3 files changed

+49
-3
lines changed

3 files changed

+49
-3
lines changed

muted-tests.yml

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,4 +411,37 @@ tests:
411411
issue: https://github.com/elastic/elasticsearch/issues/126085
412412
- class: org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT
413413
method: test {yaml=reference/search/retriever/line_906}
414-
issue: https://github.com/elastic/elasticsearch/issues/131041
414+
issue: https://github.com/elastic/elasticsearch/issues/131041
415+
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
416+
method: testPushDownUpperCaseChangeRLike
417+
issue: https://github.com/elastic/elasticsearch/issues/131041
418+
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
419+
method: testChangeCaseAsInsensitiveWildcardLikeNotPushedDown
420+
issue: https://github.com/elastic/elasticsearch/issues/131041
421+
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
422+
method: testPushDownUpperCaseChangeLike
423+
issue: https://github.com/elastic/elasticsearch/issues/131041
424+
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
425+
method: testPushDownLowerCaseChangeRLike
426+
issue: https://github.com/elastic/elasticsearch/issues/131041
427+
- class: org.elasticsearch.xpack.esql.optimizer.PhysicalPlanOptimizerTests
428+
method: testPushDownLowerCaseChangeLike
429+
issue: https://github.com/elastic/elasticsearch/issues/131041
430+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
431+
method: testReplaceUpperStringCasinqgWithInsensitiveRLike
432+
issue: https://github.com/elastic/elasticsearch/issues/131041
433+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
434+
method: testReplaceLowerStringCasingWithInsensitiveRLike
435+
issue: https://github.com/elastic/elasticsearch/issues/131041
436+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
437+
method: testReplaceLowerStringCasingWithInsensitiveLike
438+
issue: https://github.com/elastic/elasticsearch/issues/131041
439+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
440+
method: testReplaceUpperStringCasingWithInsensitiveLike
441+
issue: https://github.com/elastic/elasticsearch/issues/131041
442+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
443+
method: testReplaceStringCasingAndLikeWithLocalRelation
444+
issue: https://github.com/elastic/elasticsearch/issues/131041
445+
- class: org.elasticsearch.xpack.esql.optimizer.LocalLogicalPlanOptimizerTests
446+
method: testReplaceStringCasingAndRLikeWithLocalRelation
447+
issue: https://github.com/elastic/elasticsearch/issues/131041

x-pack/plugin/esql/qa/testFixtures/src/main/resources/where-like.csv-spec

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,3 +874,15 @@ emp_no:integer |first_name:keyword
874874
10001 |Georgi
875875
10055 |Georgy
876876
;
877+
878+
rlikeWithLowerTurnedInsensitiveUnicode#[skip:-8.18.99]
879+
FROM airport_city_boundaries
880+
| WHERE TO_UPPER(region) RLIKE ".*Л.*" and abbrev == "FRU"
881+
| KEEP region
882+
;
883+
884+
region:text
885+
Свердлов району
886+
;
887+
888+

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import org.elasticsearch.xpack.esql.optimizer.rules.logical.PropagateEmptyRelation;
1111
import org.elasticsearch.xpack.esql.optimizer.rules.logical.ReplaceStatsFilteredAggWithEval;
12-
import org.elasticsearch.xpack.esql.optimizer.rules.logical.ReplaceStringCasingWithInsensitiveRegexMatch;
1312
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.InferIsNotNull;
1413
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.InferNonNullAggConstraint;
1514
import org.elasticsearch.xpack.esql.optimizer.rules.logical.local.LocalPropagateEmptyRelation;
@@ -75,7 +74,9 @@ private static Batch<LogicalPlan> localOperators() {
7574
}
7675

7776
// add rule that should only apply locally
78-
newRules.add(new ReplaceStringCasingWithInsensitiveRegexMatch());
77+
// Disabled until Unicode CASE_INSENSITIVE support is added to Lucine 9.0
78+
// waiting on https://github.com/elastic/elasticsearch/issues/131386
79+
// newRules.add(new ReplaceStringCasingWithInsensitiveRegexMatch());
7980

8081
return operators.with(newRules.toArray(Rule[]::new));
8182
}

0 commit comments

Comments
 (0)