Refactor thin and cluster process

Author: juliohm

src/processes/cluster.jl

@@ -75,7 +75,7 @@ function randsingle(rng::Random.AbstractRNG, p::ClusterProcess, g)
 
   # combine offsprings into single set
   points = mapreduce(vcat, offsprings) do pset
-    isnothing(pset) ? Point{Dim,T}[] : collect(view(pset, g))
+    isnothing(pset) ? Point{Dim,T}[] : collect(pset ∩ g)
   end
 
   # return point pattern

src/processes/poisson.jl

@@ -47,7 +47,7 @@ function randsingle(rng::Random.AbstractRNG, p::PoissonProcess{<:Function}, g)
   pset = randsingle(rng, PoissonProcess(λmax), g)
 
   # thin point pattern
-  isnothing(pset) ? nothing : PointSet(collect(thin(pset, RandomThinning(x -> p.λ(x) / λmax))))
+  isnothing(pset) ? nothing : thin(pset, RandomThinning(x -> p.λ(x) / λmax))
 end
 
 function randsingle(rng::Random.AbstractRNG, p::PoissonProcess{<:AbstractVector}, d::Domain)

src/thinning/random.jl

@@ -39,7 +39,8 @@ thin(p::PoissonProcess{<:Function}, t::RandomThinning{<:Real}) = PoissonProcess(
 function thin(pp::PointSet, t::RandomThinning{<:Real})
   draws = rand(Bernoulli(t.p), nelements(pp))
   inds = findall(isequal(1), draws)
-  view(pp, inds)
+  points = collect(view(pp, inds))
+  PointSet(points)
 end
 
 function thin(pp::PointSet, t::RandomThinning{<:Function})
@@ -50,5 +51,6 @@ function thin(pp::PointSet, t::RandomThinning{<:Function})
       push!(inds, j)
     end
   end
-  view(pp, inds)
+  points = collect(view(pp, inds))
+  PointSet(points)
 end