Some config settings ignored in dshield.php

[gatheall]

Configuration settings such as 'ccaddr' are ignored in dshield.php because the $config array gets overwritten when processing the functions.inc include. One solution is to rename the array in the script (eg, $config -> $dshield_config) for those settings intended to be defined in dshield.ini.

Note, though, that notification settings (eg, $config['notifications']['smtp']['ipaddress']) are defined not in dshield.ini but in /cf/conf/config.xml and thus should not be renamed.

[gatheall]

This also affects the composition of log lines submitted to dshield as the 'uid' setting is referenced after including functions.inc.

[gatheall]

Some notification settings (eg, $config['notifications']['smtp']['fromaddress']) are used in dshield.php before they are populated in the include files.

Note that this means the check of whether $config['notifications']['smtp']['ipaddress'] is set won't fail when an email server is configured in pfSense (under System / Advanced / Notifications). That said, I suspect the check should be reversed; ie, exit if it is not set.

[gatheall]

I'll work on a pull request to fix this.